You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sentry.apache.org by Xiaomeng Huang <xi...@intel.com> on 2015/02/03 06:18:28 UTC

Review Request 30542: SENTRY-537: Refactor AbstractTestWithHiveServer to cut down some test cases runtime

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30542/
-----------------------------------------------------------

Review request for sentry and Colin Ma.


Bugs: SETNRY-537
    https://issues.apache.org/jira/browse/SETNRY-537


Repository: sentry


Description
-------

Some test classes which extends AbstractTestWithHiveServer run every test to setup hiveserver and create context, please see TestServerConfiguration, every test will setup hiveserver. I think we can start hiveserver in beforeClass to reduce test case runtime.


Diffs
-----

  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java 04f50ed 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java 1af8baa 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithHAGrantOption.java 84f998e 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithHiveServer.java 9b3c04a 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestServerConfiguration.java d8ebea6 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestViewPrivileges.java 0595ffb 

Diff: https://reviews.apache.org/r/30542/diff/


Testing
-------

test cases all passed.


Thanks,

Xiaomeng Huang