You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/11 10:10:12 UTC

[jira] [Commented] (BEAM-272) Flink Runner depends on Dataflow Runner

    [ https://issues.apache.org/jira/browse/BEAM-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279893#comment-15279893 ] 

ASF GitHub Bot commented on BEAM-272:
-------------------------------------

GitHub user mxm opened a pull request:

    https://github.com/apache/incubator-beam/pull/324

    [BEAM-272][flink] remove dependency on Dataflow Runner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mxm/incubator-beam BEAM-272

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #324
    
----
commit abfe73a962624001022a83ce4dd5c1697037bdbf
Author: Maximilian Michels <mx...@apache.org>
Date:   2016-05-11T09:57:44Z

    [BEAM-272][flink] remove dependency on Dataflow Runner

----


> Flink Runner depends on Dataflow Runner
> ---------------------------------------
>
>                 Key: BEAM-272
>                 URL: https://issues.apache.org/jira/browse/BEAM-272
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>
> During restructuring of the modules, we have introduced a dependency of the Flink Runner on the Dataflow Runner. The {{PipelineOptionsFactory}} used to be part of the SDK core but moved to the Dataflow Runner. We should get rid of this dependency to avoid classpath related problems.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)