You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/03/31 21:58:49 UTC

[GitHub] brooklyn-server pull request: Fix persisting localhost

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/97

    Fix persisting localhost

    When running `org.apache.brooklyn.qa.load.LoadTest`, I hit exceptions about serializing localhost machine location. I didn't try rebinding, but I presume the localhost machine's location object would not have been deserialised correctly (or not been available at all).
    
    This PR fixes the two exceptions I hit.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server fix/persisting-localhost

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/97.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #97
    
----
commit f0b1bf8cb832f4c000f3c9a7c43327ec5aabd82f
Author: Aled Sage <al...@gmail.com>
Date:   2016-03-31T19:50:59Z

    Localhost machine: don’t persist mutexSupport
    
    By passing mutexSupport in the machine’s config, it is persisted. But
    this tries to pull in persisting threads etc!
    
    It is not necessary to pass it: the Localhost machine overrides the
    getMutexSupport().

commit 2dadb24b9b8e458d4dc1ebe4429d070913036679
Author: Aled Sage <al...@gmail.com>
Date:   2016-03-31T19:51:26Z

    Task serializer: avoid NPE if task result is null

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request: Fix persisting localhost

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/97


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request: Fix persisting localhost

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:

    https://github.com/apache/brooklyn-server/pull/97#issuecomment-204303337
  
    yeah the `mutexSupport` is static so not sure why we go to such great lengths to pass it around; LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---