You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "TanYuxin-tyx (via GitHub)" <gi...@apache.org> on 2023/04/26 11:55:03 UTC

[GitHub] [flink] TanYuxin-tyx commented on pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5

TanYuxin-tyx commented on PR #22427:
URL: https://github.com/apache/flink/pull/22427#issuecomment-1523290741

   @JunRuiLee Thanks for joining the review. Considering that the two base classes have many table-related and Scala-related subclasses, it is indeed necessary to upgrade all the subclasses to JUnit5. However, I don't believe it is appropriate to update all the tests in this PR. Perhaps we should seek input from others to generate more ideas.
   
    @godfreyhe could you please help take a look at this change, WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org