You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "hubgeter (via GitHub)" <gi...@apache.org> on 2026/01/22 02:37:15 UTC

[PR] [fix](parqeut)Fixed a performance fallback caused by filling RL DL when reading Parquet scalar columns. (#59833) [doris]

hubgeter opened a new pull request, #60130:
URL: https://github.com/apache/doris/pull/60130

   Related PR: #58785
   
   Problem Summary:
   The performance rollback was introduced in #58785. The reason is that, prior to #58785, reading ordinary columns did not require filling and saving the RL DL. #58785 combined the logic for reading ordinary columns from a struct with the logic for reading ordinary columns, and filled and saved the RL DL to populate the null map information of the struct. This PR re-separates the reading logic.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [fix](parqeut)Fixed a performance fallback caused by filling RL DL when reading Parquet scalar columns. (#59833) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60130:
URL: https://github.com/apache/doris/pull/60130#issuecomment-3783075408

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [fix](parqeut)Fixed a performance fallback caused by filling RL DL when reading Parquet scalar columns. (#59833) [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #60130:
URL: https://github.com/apache/doris/pull/60130


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [fix](parqeut)Fixed a performance fallback caused by filling RL DL when reading Parquet scalar columns. (#59833) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60130:
URL: https://github.com/apache/doris/pull/60130#issuecomment-3783075543

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [fix](parqeut)Fixed a performance fallback caused by filling RL DL when reading Parquet scalar columns. (#59833) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60130:
URL: https://github.com/apache/doris/pull/60130#issuecomment-3782457915

   # BE UT Coverage Report
   Increment line coverage `80.00% (20/25)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/6cc74e94796fa805c08e217ab2921e56c428b031_6cc74e94796fa805c08e217ab2921e56c428b031/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/6cc74e94796fa805c08e217ab2921e56c428b031_6cc74e94796fa805c08e217ab2921e56c428b031/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.72% (18899/35848) |
   | Line Coverage     | 35.83% (175471/489674) |
   | Region Coverage   | 32.48% (135761/417994) |
   | Branch Coverage   | 33.34% (58862/176548) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [fix](parqeut)Fixed a performance fallback caused by filling RL DL when reading Parquet scalar columns. (#59833) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60130:
URL: https://github.com/apache/doris/pull/60130#issuecomment-3782186494

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [PR] [fix](parqeut)Fixed a performance fallback caused by filling RL DL when reading Parquet scalar columns. (#59833) [doris]

Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #60130:
URL: https://github.com/apache/doris/pull/60130#issuecomment-3782186739

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org