[GitHub] [incubator-druid] himanshug commented on a change in pull request #8426: groupBy query: optional limit push down to segment scan

[GitBox <gi...@apache.org>]

himanshug commented on a change in pull request #8426:  groupBy query: optional limit push down to segment scan
URL: https://github.com/apache/incubator-druid/pull/8426#discussion_r327798746
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryConfig.java
 ##########
 @@ -78,6 +79,9 @@
   @JsonProperty
   private boolean forcePushDownLimit = false;
 
+  @JsonProperty
+  private boolean applyLimitPushDownToSegment = true;
 
 Review comment:
   main reason to have this flag to allow users to go back to older behavior in case a bug is found. TBH , that was my biggest concern to have the flag.
   
   that said, in certain pathological case, overhead of maintaining the min-max heap might be more costly than savings from that, so it could be disabled. but is true for pushing down limits feature in general which is always on at least in the merge phase.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org