You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/05/20 09:34:29 UTC
[GitHub] [incubator-brpc] liumh8 opened a new issue #1119: RedisCommandHandler在多连接场景下，做不了batch？
liumh8 opened a new issue #1119:
URL: https://github.com/apache/incubator-brpc/issues/1119
如果在某个连接上，[flush_batched](https://github.com/apache/incubator-brpc/blob/a3b22660096c4f00cfdffc7571063603ccb5a428/src/brpc/redis.h#L264)为false的情况下，缓存了几条命令，这时候RedisCommandHandler处理另一条连接的请求，且flush_batched为true，将已缓存的命令都处理完返回，但是其中一些命令是来自其他连接的。请问是否有这样的问题？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] liumh8 commented on issue #1119: RedisCommandHandler在多连接场景下，做不了batch？
Posted by GitBox <gi...@apache.org>.
liumh8 commented on issue #1119:
URL: https://github.com/apache/incubator-brpc/issues/1119#issuecomment-633935973
> 是的，目前有这个问题，正在计划修复，先用非batch版本吧。
请问这个大概什么时候能修复好？此外，有另一个问题，对于一个命令'set key value'，RedisCommandHandler的Run函数提供了[const std::vector<const char*>& args](https://github.com/apache/incubator-brpc/blob/a3b22660096c4f00cfdffc7571063603ccb5a428/src/brpc/redis.h#L262)这个参数，但是如果value里面包含字符 '\0'，该怎么处理？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] liumh8 edited a comment on issue #1119: RedisCommandHandler在多连接场景下，做不了batch？
Posted by GitBox <gi...@apache.org>.
liumh8 edited a comment on issue #1119:
URL: https://github.com/apache/incubator-brpc/issues/1119#issuecomment-633935973
> 是的，目前有这个问题，正在计划修复，先用非batch版本吧。
@zyearn 请问这个大概什么时候能修复好？此外，有另一个问题，对于一个命令'set key value'，RedisCommandHandler的Run函数提供了[const std::vector<const char*>& args](https://github.com/apache/incubator-brpc/blob/a3b22660096c4f00cfdffc7571063603ccb5a428/src/brpc/redis.h#L262)这个参数，但是如果value里面包含字符 '\0'，该怎么处理？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] liumh8 closed issue #1119: RedisCommandHandler在多连接场景下，做不了batch？
Posted by GitBox <gi...@apache.org>.
liumh8 closed issue #1119:
URL: https://github.com/apache/incubator-brpc/issues/1119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] liumh8 commented on issue #1119: RedisCommandHandler在多连接场景下，做不了batch？
Posted by GitBox <gi...@apache.org>.
liumh8 commented on issue #1119:
URL: https://github.com/apache/incubator-brpc/issues/1119#issuecomment-631380008
@zyearn 请问是否有这样的问题？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on issue #1119: RedisCommandHandler在多连接场景下，做不了batch？
Posted by GitBox <gi...@apache.org>.
zyearn commented on issue #1119:
URL: https://github.com/apache/incubator-brpc/issues/1119#issuecomment-631396573
是的，目前有这个问题，正在计划修复，先用非batch版本吧。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyearn commented on issue #1119: RedisCommandHandler在多连接场景下，做不了batch？
Posted by GitBox <gi...@apache.org>.
zyearn commented on issue #1119:
URL: https://github.com/apache/incubator-brpc/issues/1119#issuecomment-635064453
> > 是的，目前有这个问题，正在计划修复，先用非batch版本吧。
>
> @zyearn 请问这个大概什么时候能修复好？此外，有另一个问题，对于一个命令'set key value'，RedisCommandHandler的Run函数提供了[const std::vector<const char*>& args](https://github.com/apache/incubator-brpc/blob/a3b22660096c4f00cfdffc7571063603ccb5a428/src/brpc/redis.h#L262)这个参数，但是如果value里面包含字符 '\0'，该怎么处理？
batch的问题会尽快修复，可能1~2周。目前的实现value不是二进制安全的，可以先做个base64来绕过这个问题。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org