You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/09 01:23:03 UTC

[GitHub] [flink-docker] wangxiyuan edited a comment on pull request #23: [FLINK-14241][test]Add arm64 support for docker e2e test

wangxiyuan edited a comment on pull request #23:
URL: https://github.com/apache/flink-docker/pull/23#issuecomment-689237514


   > I'm not sure if this PR works as-is. The updated generator doesn't seem to set the architecture flag correctly: https://github.com/apache/flink-docker/pull/23/files#diff-0c5f825c10334c2eff0a90687f513c69R93
   > 
   > also, the architecture seems to depend on the architecture of the machine executing the `generate.sh` script. But this script only generates the Dockerfile and metadata file, not the actual docker image.
   
   Yeah, many docker images support multi arch now, for example `openjdk:11-jre` [1]. For this kind of image, we don't need to change any code here of cause. Different machine use different image automatically.
   
   But there are still some images don't support arm64, for example, the image `openjdk:8-jre`[2]  which the e2e test uses. For this kind of image, we should use the image from another official repo `arm64v8`[3].
   
   Now openlab runs flink e2e test on arm64 with my forked `flink-docker` repo.[4] And the test runs well[5]
   
   
   [1]: https://hub.docker.com/layers/openjdk/library/openjdk/11-jre/images/sha256-9ea29bab2ef2eebaf0d9693cfab073fbdc560f2abe37be5885eede04a41188f8?context=explore
   [2]: https://hub.docker.com/layers/openjdk/library/openjdk/8-jre/images/sha256-41aefd23ef94a79df24c0d534d80eefd3c1fbc4f3810f3c2211dffb2e2736fe1?context=explore
   [3]: https://hub.docker.com/layers/arm64v8/openjdk/8-jre/images/sha256-b915aa8067ed0f7bdadb94701109b4408ee6d90642181c87ad37ff4036e0aed5?context=explore
   [4]: https://github.com/wangxiyuan/flink-docker/blob/dev-master/generator.sh#L18-L22
   [5]: http://status.openlabtesting.org/builds?job_name=flink-end-to-end-test-cron-hadoop313


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org