You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jinossy <gi...@git.apache.org> on 2014/08/03 16:10:31 UTC
[GitHub] tajo pull request: TAJO-989: Cleanup of child blocks after parent ...
GitHub user jinossy opened a pull request:
https://github.com/apache/tajo/pull/103
TAJO-989: Cleanup of child blocks after parent execution block is comple...
...te
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinossy/tajo TAJO-989
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/103.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #103
----
commit 5b55e875e3a8b060dd08c9d3a981062fd61dfda4
Author: jinossy <ji...@gmail.com>
Date: 2014-08-03T14:07:58Z
TAJO-989: Cleanup of child blocks after parent execution block is complete
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-989: Cleanup of child blocks after parent ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/103#discussion_r15741058
--- Diff: tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java ---
@@ -363,7 +364,7 @@ public void addTask(QueryUnit task) {
* It finalizes this subquery. It is only invoked when the subquery is succeeded.
*/
public void complete() {
- cleanup();
+ cleanup(getId());
--- End diff --
You can get the block id by calling ```block.getId()```. So, cleanup() doesn't need to take an execution block id.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-989: Cleanup of child blocks after parent ...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/103#issuecomment-51144284
Thank you for the review. I reflected your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-989: Cleanup of child blocks after parent ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/103#discussion_r15741073
--- Diff: tajo-core/src/main/java/org/apache/tajo/worker/Task.java ---
@@ -27,6 +27,7 @@
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.*;
import org.apache.hadoop.util.ReflectionUtils;
+import org.apache.tajo.ExecutionBlockId;
--- End diff --
It's an unused import.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-989: Cleanup of child blocks after parent ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/103#issuecomment-51019328
+1
This work will remove unnecessary intermediate data earlier than the current implementation. The motivation is reasonable and the patch looks nice to me.
I leaved one trivial comment. If you agree with my comment, you can commit it after refactoring SubQuery::cleanup method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-989: Cleanup of child blocks after parent ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/103
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---