You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Cong Wang <xi...@gmail.com> on 2016/02/25 18:59:22 UTC
Review Request 44026: Moved future tests into future_tests.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44026/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Repository: mesos
Description
-------
Moved future tests into future_tests.cpp.
Diffs
-----
3rdparty/libprocess/src/tests/future_tests.cpp ded1aaed25876d45e33b4a27fffc6a5c46ca92f5
3rdparty/libprocess/src/tests/process_tests.cpp e9bf80ee69f4add299cb828ed3245ac07398943c
Diff: https://reviews.apache.org/r/44026/diff/
Testing
-------
make check
Thanks,
Cong Wang
Re: Review Request 44026: Moved future tests into future_tests.cpp.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44026/#review122949
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On March 9, 2016, 7:25 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44026/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 7:25 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved future tests into future_tests.cpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/future_tests.cpp ded1aaed25876d45e33b4a27fffc6a5c46ca92f5
> 3rdparty/libprocess/src/tests/process_tests.cpp e9bf80ee69f4add299cb828ed3245ac07398943c
>
> Diff: https://reviews.apache.org/r/44026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 44026: Moved future tests into future_tests.cpp.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44026/#review122869
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44026]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 9, 2016, 7:25 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44026/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 7:25 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved future tests into future_tests.cpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/future_tests.cpp ded1aaed25876d45e33b4a27fffc6a5c46ca92f5
> 3rdparty/libprocess/src/tests/process_tests.cpp e9bf80ee69f4add299cb828ed3245ac07398943c
>
> Diff: https://reviews.apache.org/r/44026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 44026: Moved future tests into future_tests.cpp.
Posted by Cong Wang <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44026/
-----------------------------------------------------------
(Updated March 9, 2016, 7:25 p.m.)
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Changes
-------
Move FromTry test as suggested by Anand
Repository: mesos
Description
-------
Moved future tests into future_tests.cpp.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/future_tests.cpp ded1aaed25876d45e33b4a27fffc6a5c46ca92f5
3rdparty/libprocess/src/tests/process_tests.cpp e9bf80ee69f4add299cb828ed3245ac07398943c
Diff: https://reviews.apache.org/r/44026/diff/
Testing
-------
make check
Thanks,
Cong Wang
Re: Review Request 44026: Moved future tests into future_tests.cpp.
Posted by Cong Wang <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44026/
-----------------------------------------------------------
(Updated March 9, 2016, 7:01 p.m.)
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Changes
-------
Rebase
Repository: mesos
Description
-------
Moved future tests into future_tests.cpp.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/future_tests.cpp ded1aaed25876d45e33b4a27fffc6a5c46ca92f5
3rdparty/libprocess/src/tests/process_tests.cpp e9bf80ee69f4add299cb828ed3245ac07398943c
Diff: https://reviews.apache.org/r/44026/diff/
Testing
-------
make check
Thanks,
Cong Wang
Re: Review Request 44026: Moved future tests into future_tests.cpp.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44026/#review120806
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44026]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 25, 2016, 5:59 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44026/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 5:59 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved future tests into future_tests.cpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/future_tests.cpp ded1aaed25876d45e33b4a27fffc6a5c46ca92f5
> 3rdparty/libprocess/src/tests/process_tests.cpp e9bf80ee69f4add299cb828ed3245ac07398943c
>
> Diff: https://reviews.apache.org/r/44026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 44026: Moved future tests into future_tests.cpp.
Posted by Cong Wang <xi...@gmail.com>.
> On Feb. 26, 2016, 1:45 a.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp, lines 1764-1776
> > <https://reviews.apache.org/r/44026/diff/1/?file=1271139#file1271139line1764>
> >
> > Should this be moved to `future_tests.cpp` too?
Yes, it should, because this is a pure Future test, not related to process.
- Cong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44026/#review120813
-----------------------------------------------------------
On Feb. 25, 2016, 5:59 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44026/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 5:59 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved future tests into future_tests.cpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/future_tests.cpp ded1aaed25876d45e33b4a27fffc6a5c46ca92f5
> 3rdparty/libprocess/src/tests/process_tests.cpp e9bf80ee69f4add299cb828ed3245ac07398943c
>
> Diff: https://reviews.apache.org/r/44026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 44026: Moved future tests into future_tests.cpp.
Posted by Anand Mazumdar <ma...@gmail.com>.
> On Feb. 26, 2016, 1:45 a.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp, lines 1764-1776
> > <https://reviews.apache.org/r/44026/diff/1/?file=1271139#file1271139line1764>
> >
> > Should this be moved to `future_tests.cpp` too?
>
> Cong Wang wrote:
> Yes, it should, because this is a pure Future test, not related to process.
Sorry, I missed this response. Why was the issue dropped when you _agreed_ that this test needs to be moved too?
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44026/#review120813
-----------------------------------------------------------
On March 9, 2016, 7:01 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44026/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 7:01 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved future tests into future_tests.cpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/future_tests.cpp ded1aaed25876d45e33b4a27fffc6a5c46ca92f5
> 3rdparty/libprocess/src/tests/process_tests.cpp e9bf80ee69f4add299cb828ed3245ac07398943c
>
> Diff: https://reviews.apache.org/r/44026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 44026: Moved future tests into future_tests.cpp.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44026/#review120813
-----------------------------------------------------------
Fix it, then Ship it!
LGTM, Just one minor query around moving one more additional test.
Thanks for resolving this tech debt.
3rdparty/libprocess/src/tests/process_tests.cpp (lines 1300 - 1312)
<https://reviews.apache.org/r/44026/#comment182314>
Should this be moved to `future_tests.cpp` too?
- Anand Mazumdar
On Feb. 25, 2016, 5:59 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44026/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 5:59 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved future tests into future_tests.cpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/future_tests.cpp ded1aaed25876d45e33b4a27fffc6a5c46ca92f5
> 3rdparty/libprocess/src/tests/process_tests.cpp e9bf80ee69f4add299cb828ed3245ac07398943c
>
> Diff: https://reviews.apache.org/r/44026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cong Wang
>
>