You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/04/30 09:14:32 UTC
Review Request 66868: Used `operator->` instead of `get`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66868/
-----------------------------------------------------------
Review request for mesos and Armand Grillet.
Repository: mesos
Description
-------
Used `operator->` instead of `get`.
Diffs
-----
src/tests/disk_profile_adaptor_tests.cpp ce11d47d2cc95abcdc80f4d40ea4d005cabbc586
Diff: https://reviews.apache.org/r/66868/diff/1/
Testing
-------
With grpc enabled:
* `make check`
* ran mesos-tidy
Thanks,
Benjamin Bannier
Re: Review Request 66868: Used `operator->` instead of `get`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66868/#review202114
-----------------------------------------------------------
PASS: Mesos patch 66868 was successfully built and tested.
Reviews applied: `['66868']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66868
- Mesos Reviewbot Windows
On April 30, 2018, 9:14 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66868/
> -----------------------------------------------------------
>
> (Updated April 30, 2018, 9:14 a.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used `operator->` instead of `get`.
>
>
> Diffs
> -----
>
> src/tests/disk_profile_adaptor_tests.cpp ce11d47d2cc95abcdc80f4d40ea4d005cabbc586
>
>
> Diff: https://reviews.apache.org/r/66868/diff/1/
>
>
> Testing
> -------
>
> With grpc enabled:
>
> * `make check`
> * ran mesos-tidy
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 66868: Used `operator->` instead of `get`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66868/#review202116
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66868]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 30, 2018, 9:14 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66868/
> -----------------------------------------------------------
>
> (Updated April 30, 2018, 9:14 a.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used `operator->` instead of `get`.
>
>
> Diffs
> -----
>
> src/tests/disk_profile_adaptor_tests.cpp ce11d47d2cc95abcdc80f4d40ea4d005cabbc586
>
>
> Diff: https://reviews.apache.org/r/66868/diff/1/
>
>
> Testing
> -------
>
> With grpc enabled:
>
> * `make check`
> * ran mesos-tidy
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 66868: Used `operator->` instead of `get`.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66868/#review202113
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On April 30, 2018, 9:14 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66868/
> -----------------------------------------------------------
>
> (Updated April 30, 2018, 9:14 a.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used `operator->` instead of `get`.
>
>
> Diffs
> -----
>
> src/tests/disk_profile_adaptor_tests.cpp ce11d47d2cc95abcdc80f4d40ea4d005cabbc586
>
>
> Diff: https://reviews.apache.org/r/66868/diff/1/
>
>
> Testing
> -------
>
> With grpc enabled:
>
> * `make check`
> * ran mesos-tidy
>
>
> Thanks,
>
> Benjamin Bannier
>
>