You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/07/29 04:37:18 UTC
[PR] fix(access-control-service, v1.2): include port in computing unit pod URI and use Envoy Gateway for distributed CUs [texera]
Yicong-Huang opened a new pull request, #7009:
URL: https://github.com/apache/texera/pull/7009
### What changes were proposed in this PR?
Backport of #5629 to `release/v1.2`, cherry-picked from 07724d54fda8b1425489fa31143c5a15738578ba.
Resolved a package-path divergence in the imports: `release/v1.2` uses `org.apache.texera.config` (main uses `org.apache.texera.common.config`). Kept v1.2's package path and added the `org.apache.texera.dao.SqlServer` import the fix needs; dropped the now-unused `KubernetesConfig` import. Source + tests backported.
### Any related issues, documentation, discussions?
Backport of #5629. Originally linked #5630.
### How was this PR tested?
Release-branch CI runs on this PR.
### Was this PR authored or co-authored using generative AI tooling?
Yes — backport prepared with Claude Code (cherry-pick + manual conflict resolution; the change itself is #5629 by its original author).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(access-control-service, v1.2): include port in computing unit pod URI and use Envoy Gateway for distributed CUs [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7009:
URL: https://github.com/apache/texera/pull/7009#issuecomment-5114797712
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7009?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.95%. Comparing base ([`fd5f487`](https://app.codecov.io/gh/apache/texera/commit/fd5f487074190d00d26c9ba4af2bced7246398de?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2f7bec1`](https://app.codecov.io/gh/apache/texera/commit/2f7bec128c4624b6e7d741caf8fcc38df099ebde?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on release/v1.2.
:white_check_mark: All tests successful. No failed tests found.
| [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/7009?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...exera/service/resource/AccessControlResource.scala](https://app.codecov.io/gh/apache/texera/pull/7009?src=pr&el=tree&filepath=access-control-service%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Ftexera%2Fservice%2Fresource%2FAccessControlResource.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YWNjZXNzLWNvbnRyb2wtc2VydmljZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3RleGVyYS9zZXJ2aWNlL3Jlc291cmNlL0FjY2Vzc0NvbnRyb2xSZXNvdXJjZS5zY2FsYQ==) | 72.72% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/texera/pull/7009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/texera/service/util/KubernetesClient.scala](https://app.codecov.io/gh/apache/texera/pull/7009?src=pr&el=tree&filepath=computing-unit-managing-service%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Ftexera%2Fservice%2Futil%2FKubernetesClient.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcHV0aW5nLXVuaXQtbWFuYWdpbmctc2VydmljZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3RleGVyYS9zZXJ2aWNlL3V0aWwvS3ViZXJuZXRlc0NsaWVudC5zY2FsYQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/texera/pull/7009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## release/v1.2 #7009 +/- ##
===============================================
Coverage 53.95% 53.95%
Complexity 1441 1441
===============================================
Files 809 809
Lines 34144 34151 +7
Branches 3448 3452 +4
===============================================
+ Hits 18421 18425 +4
Misses 14815 14815
- Partials 908 911 +3
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/7009/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7009/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.35% <72.72%> (-0.26%)` | :arrow_down: | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/7009/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.36% <ø> (ø)` | | Carriedforward from [fd5f487](https://app.codecov.io/gh/apache/texera/commit/fd5f487074190d00d26c9ba4af2bced7246398de?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/7009/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.61% <ø> (ø)` | | Carriedforward from [fd5f487](https://app.codecov.io/gh/apache/texera/commit/fd5f487074190d00d26c9ba4af2bced7246398de?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7009/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `1.65% <0.00%> (ø)` | | |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/7009/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.06% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/7009/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.59% <ø> (ø)` | | |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/7009/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.19% <ø> (ø)` | | Carriedforward from [fd5f487](https://app.codecov.io/gh/apache/texera/commit/fd5f487074190d00d26c9ba4af2bced7246398de?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/7009/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.87% <ø> (ø)` | | Carriedforward from [fd5f487](https://app.codecov.io/gh/apache/texera/commit/fd5f487074190d00d26c9ba4af2bced7246398de?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/7009/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.74% <ø> (ø)` | | Carriedforward from [fd5f487](https://app.codecov.io/gh/apache/texera/commit/fd5f487074190d00d26c9ba4af2bced7246398de?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7009/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.69% <ø> (ø)` | | |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7009?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(access-control-service, v1.2): include port in computing unit pod URI and use Envoy Gateway for distributed CUs [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7009:
URL: https://github.com/apache/texera/pull/7009#issuecomment-5113317619
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@SarahAsad23`, `@aglinxinyuan`
You can notify them by mentioning `@SarahAsad23`, `@aglinxinyuan` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(access-control-service, v1.2): include port in computing unit pod URI and use Envoy Gateway for distributed CUs [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 merged PR #7009:
URL: https://github.com/apache/texera/pull/7009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org