[GitHub] [spark] jiangxb1987 commented on a change in pull request #28746: [SPARK-31922][CORE] Fix "RpcEnv already stopped" error when exit spark-shell with local-cluster mode

[GitBox <gi...@apache.org>]

jiangxb1987 commented on a change in pull request #28746:
URL: https://github.com/apache/spark/pull/28746#discussion_r436492690



##########
File path: core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala
##########
@@ -74,12 +74,17 @@ class LocalSparkCluster(
 
   def stop(): Unit = {
     logInfo("Shutting down local Spark cluster.")
+    // SPARK-31922: wait one more second before shutting down rpcEnvs of master and worker,
+    // in order to let the cluster have time to handle the `UnregisterApplication` message.
+    // Otherwise, we could hit "RpcEnv already stopped" error.
+    Thread.sleep(1000)
     // Stop the workers before the master so they don't get upset that it disconnected
-    workerRpcEnvs.foreach(_.shutdown())
-    masterRpcEnvs.foreach(_.shutdown())
-    workerRpcEnvs.foreach(_.awaitTermination())
-    masterRpcEnvs.foreach(_.awaitTermination())
-    masterRpcEnvs.clear()
-    workerRpcEnvs.clear()
+    Seq(workerRpcEnvs, masterRpcEnvs).foreach { rpcEnvArr =>
+      rpcEnvArr.foreach { rpcEnv => Utils.tryLog {
+        rpcEnv.shutdown()
+        rpcEnv.awaitTermination()
+      }}
+      rpcEnvArr.clear()

Review comment:
       I doubt this is right, it seems previously the masterRpcEnvs are cleared before workerRpcEnvs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org