You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Viknes B <vi...@msn.com> on 2012/08/10 20:27:00 UTC

Review Request: Add/Remove Friend

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6527/
-----------------------------------------------------------

Review request for rave.


Description
-------

Ability to add and remove friends in Rave.

This is the initial implementation to send friend requests. Accepting the requests is yet to be implemented.


This addresses bug Rave-690.
    https://issues.apache.org/jira/browse/Rave-690


Diffs
-----

  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/FriendRequestStatus.java PRE-CREATION 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Person.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/PersonImpl.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/UserImpl.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/PersonRepository.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaPerson.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaPersonAssociation.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaUser.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaPersonConverter.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaUserConverter.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaPersonRepository.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaPersonConverterTest.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaUserConverterTest.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rpc/PersonApi.java PRE-CREATION 
  https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_api.js 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_person_profile.js 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/repository/impl/DecoratingOpenSocialPersonRepository.java 1371800 

Diff: https://reviews.apache.org/r/6527/diff/


Testing
-------


Thanks,

Viknes B


Re: Review Request: Add/Remove Friend

Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6527/#review10235
-----------------------------------------------------------

Ship it!


Ship It!

- Raminder Singh


On Aug. 13, 2012, 3:40 p.m., Viknes B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6527/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2012, 3:40 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Ability to add and remove friends in Rave.
> 
> This is the initial implementation to send friend requests. Accepting the requests is yet to be implemented.
> 
> 
> This addresses bug Rave-690.
>     https://issues.apache.org/jira/browse/Rave-690
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/FriendRequestStatus.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Person.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/PersonImpl.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/UserImpl.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/PersonRepository.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaPerson.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaPersonAssociation.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaUser.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaPersonConverter.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaUserConverter.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaPersonRepository.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaPersonConverterTest.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaUserConverterTest.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rpc/PersonApi.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_api.js 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_person_profile.js 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/repository/impl/DecoratingOpenSocialPersonRepository.java 1371800 
> 
> Diff: https://reviews.apache.org/r/6527/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Viknes B
> 
>


Re: Review Request: Add/Remove Friend

Posted by Viknes B <vi...@msn.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6527/
-----------------------------------------------------------

(Updated Aug. 13, 2012, 3:40 p.m.)


Review request for rave.


Description
-------

Ability to add and remove friends in Rave.

This is the initial implementation to send friend requests. Accepting the requests is yet to be implemented.


This addresses bug Rave-690.
    https://issues.apache.org/jira/browse/Rave-690


Diffs (updated)
-----

  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/FriendRequestStatus.java PRE-CREATION 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Person.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/PersonImpl.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/UserImpl.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/PersonRepository.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaPerson.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaPersonAssociation.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaUser.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaPersonConverter.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaUserConverter.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaPersonRepository.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaPersonConverterTest.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaUserConverterTest.java 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rpc/PersonApi.java PRE-CREATION 
  https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_api.js 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_person_profile.js 1371800 
  https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/repository/impl/DecoratingOpenSocialPersonRepository.java 1371800 

Diff: https://reviews.apache.org/r/6527/diff/


Testing
-------


Thanks,

Viknes B


Re: Review Request: Add/Remove Friend

Posted by Viknes B <vi...@msn.com>.

> On Aug. 13, 2012, 2:55 p.m., Raminder Singh wrote:
> > Rest looks good to me. Adding a alert on delete friend will help. Right now i have to test friends by updating status in DB manually. It would be good to add confirm request feature soon.

Added alert. Will implement confirming requests soon.


> On Aug. 13, 2012, 2:55 p.m., Raminder Singh wrote:
> > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java, line 171
> > <https://reviews.apache.org/r/6527/diff/1/?file=137655#file137655line171>
> >
> >     Method comments are missing

Added !


> On Aug. 13, 2012, 2:55 p.m., Raminder Singh wrote:
> > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaPersonRepository.java, line 211
> > <https://reviews.apache.org/r/6527/diff/1/?file=137663#file137663line211>
> >
> >     Why we need 2 list objects here? Cant we handle this at display level as status will be different?

One list contains friends for a user and other list contains the friend requests of the user.
This cannot be handled at the display level because we are sending a list of 'person' objects to the frontend and not 'person association' objects. Adding a status to a person object wont make much sense.


- Viknes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6527/#review10214
-----------------------------------------------------------


On Aug. 13, 2012, 3:40 p.m., Viknes B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6527/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2012, 3:40 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Ability to add and remove friends in Rave.
> 
> This is the initial implementation to send friend requests. Accepting the requests is yet to be implemented.
> 
> 
> This addresses bug Rave-690.
>     https://issues.apache.org/jira/browse/Rave-690
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/FriendRequestStatus.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Person.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/PersonImpl.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/UserImpl.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/PersonRepository.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaPerson.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaPersonAssociation.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaUser.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaPersonConverter.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaUserConverter.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaPersonRepository.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaPersonConverterTest.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaUserConverterTest.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rpc/PersonApi.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_api.js 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_person_profile.js 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/repository/impl/DecoratingOpenSocialPersonRepository.java 1371800 
> 
> Diff: https://reviews.apache.org/r/6527/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Viknes B
> 
>


Re: Review Request: Add/Remove Friend

Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6527/#review10214
-----------------------------------------------------------


Rest looks good to me. Adding a alert on delete friend will help. Right now i have to test friends by updating status in DB manually. It would be good to add confirm request feature soon. 


https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java
<https://reviews.apache.org/r/6527/#comment21646>

    Method comments are missing



https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaPersonRepository.java
<https://reviews.apache.org/r/6527/#comment21647>

    Why we need 2 list objects here? Cant we handle this at display level as status will be different?


- Raminder Singh


On Aug. 10, 2012, 6:27 p.m., Viknes B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6527/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2012, 6:27 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Ability to add and remove friends in Rave.
> 
> This is the initial implementation to send friend requests. Accepting the requests is yet to be implemented.
> 
> 
> This addresses bug Rave-690.
>     https://issues.apache.org/jira/browse/Rave-690
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/FriendRequestStatus.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Person.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/PersonImpl.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/UserImpl.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/PersonRepository.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/UserService.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultUserService.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultUserServiceTest.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaPerson.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaPersonAssociation.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaUser.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaPersonConverter.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaUserConverter.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaPersonRepository.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaPersonConverterTest.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaUserConverterTest.java 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rpc/PersonApi.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_api.js 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/rave_person_profile.js 1371800 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/repository/impl/DecoratingOpenSocialPersonRepository.java 1371800 
> 
> Diff: https://reviews.apache.org/r/6527/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Viknes B
> 
>