You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/22 15:27:55 UTC

[GitHub] cjolivier01 commented on a change in pull request #12160: Remove conflicting llvm OpenMP from cmake builds

cjolivier01 commented on a change in pull request #12160: Remove conflicting llvm OpenMP from cmake builds
URL: https://github.com/apache/incubator-mxnet/pull/12160#discussion_r211999747
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -370,32 +370,12 @@ endif()
 # ---[ OpenMP
 if(USE_OPENMP)
   find_package(OpenMP REQUIRED)
-  # This should build on Windows, but there's some problem and I don't have a Windows box, so
-  # could a Windows user please fix?
-  if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/openmp/CMakeLists.txt
 
 Review comment:
   Are you high?  Why would you remove this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services