You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/28 09:30:22 UTC
[GitHub] [dolphinscheduler] Chris-Arith opened a new pull request, #12595: fix issue #12214
Chris-Arith opened a new pull request, #12595:
URL: https://github.com/apache/dolphinscheduler/pull/12595
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
fix issue #12214 that oracle can't connect to database which name is different with username.
## Description
Different with MySQL, Oracle can't specify a database by jdbc url.
So, it will connect to the database equals to username, but one user may have serval database to access.
We found this problem in `dataquality` module, for example, we have an user named `bddb` and we want to use database `product`, it currently not available.
So I made a little change that I can specify a schema in jdbc params.
Another way is to add an select option and let us choose from the frontend, this would be the best way.
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #12595: [Bug] [Data Quality] Oracle Can't Connect Database Different With Username #12214
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #12595:
URL: https://github.com/apache/dolphinscheduler/pull/12595#issuecomment-1328641588
And BTW, CI if faild
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on pull request #12595: [Bug] [Data Quality] Oracle Can't Connect Database Different With Username #12214
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12595:
URL: https://github.com/apache/dolphinscheduler/pull/12595#issuecomment-1648792371
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed pull request #12595: [Bug] [Data Quality] Oracle Can't Connect Database Different With Username #12214
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12595: [Bug] [Data Quality] Oracle Can't Connect Database Different With Username #12214
URL: https://github.com/apache/dolphinscheduler/pull/12595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on pull request #12595: [Bug] [Data Quality] Oracle Can't Connect Database Different With Username #12214
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12595:
URL: https://github.com/apache/dolphinscheduler/pull/12595#issuecomment-1661277650
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #12595: [Bug] [Data Quality] Oracle Can't Connect Database Different With Username #12214
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #12595:
URL: https://github.com/apache/dolphinscheduler/pull/12595#issuecomment-1328641377
@Chris-Arith can you please add some UT to `getReaderConfigList` function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org