You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Venkat Ranganathan <n....@live.com> on 2013/11/05 02:04:32 UTC
Review Request 15222: Fix for SQOOP-1224
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15222/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1224
https://issues.apache.org/jira/browse/SQOOP-1224
Repository: sqoop-trunk
Description
-------
When we use wallet based authentication (which enables secure external authentication in Oracle), the Sqoop jobs fail. The reason for this is that in a wallet based authentication, the username, password and DB information are hidden and only a service is exposed. So, all queries to which we pass the owner as a parameter will fail. This patch adds the ability to substitute the logged on Oracle user if the username is not provided (as in wallet based implementations), but can also be used for other SSO mechanisms
Diffs
-----
src/java/org/apache/sqoop/manager/OracleManager.java f6f3afa
src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 078b447
Diff: https://reviews.apache.org/r/15222/diff/
Testing
-------
Added one test to validate the query to get the current logged on user. All tests pass. No new checkstyle violations introduced
Thanks,
Venkat Ranganathan
Re: Review Request 15222: Fix for SQOOP-1224
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15222/#review28228
-----------------------------------------------------------
Ship it!
src/java/org/apache/sqoop/manager/OracleManager.java
<https://reviews.apache.org/r/15222/#comment54903>
+1
I believe that this will be even better as it will overcome the need to specify the user name with correct case on the command line!
Jarcec
- Jarek Cecho
On Nov. 5, 2013, 1:04 a.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15222/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 1:04 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1224
> https://issues.apache.org/jira/browse/SQOOP-1224
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> When we use wallet based authentication (which enables secure external authentication in Oracle), the Sqoop jobs fail. The reason for this is that in a wallet based authentication, the username, password and DB information are hidden and only a service is exposed. So, all queries to which we pass the owner as a parameter will fail. This patch adds the ability to substitute the logged on Oracle user if the username is not provided (as in wallet based implementations), but can also be used for other SSO mechanisms
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/manager/OracleManager.java f6f3afa
> src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 078b447
>
> Diff: https://reviews.apache.org/r/15222/diff/
>
>
> Testing
> -------
>
> Added one test to validate the query to get the current logged on user. All tests pass. No new checkstyle violations introduced
>
>
> Thanks,
>
> Venkat Ranganathan
>
>