You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/16 18:11:10 UTC

[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #53: update github actions due to warnings about nodejs version

pjfanning commented on code in PR #53:
URL: https://github.com/apache/incubator-pekko/pull/53#discussion_r1024345681


##########
.github/workflows/binary-compatibility-checks.yml:
##########
@@ -23,13 +23,13 @@ jobs:
         scalaVersion: [ "2.12", "2.13" ]
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           # we don't know what commit the last tag was it's safer to get entire repo so previousStableVersion resolves
           fetch-depth: 0
 
       - name: Set up JDK 8
-        uses: olafurpg/setup-scala@v10
+        uses: olafurpg/setup-scala@v13

Review Comment:
   I fixed the build issues using https://github.com/apache/incubator-pekko/pull/53/commits/ca3e39807208d10f4c085802eb8db57e11dc85a0
   
   Looks like sbtx command is now needed to get `-sbt-opts` to work - https://github.com/olafurpg/setup-scala#setup-scala-github-action



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org