[GitHub] marcoabreu commented on a change in pull request #10021: [MXNET-33] SSD example not working with mkl-dnn

[GitBox <gi...@apache.org>]

marcoabreu commented on a change in pull request #10021: [MXNET-33] SSD example not working with mkl-dnn
URL: https://github.com/apache/incubator-mxnet/pull/10021#discussion_r175081768
 
 

 ##########
 File path: tests/python/cpu/test_mkldnn.py
 ##########
 @@ -41,18 +42,49 @@ def test_mkldnn_install():
         import mxnet as mx
     except (ImportError, OSError) as e:
         assert 0, "Import mxnet error: %s. Please double check your build/" \
-               "install steps or environment variable settings" % str(e)
+            "install steps or environment variable settings" % str(e)
 
     pid = os.getpid()
-    rc = os.system("cat /proc/" + str(pid) + \
-                       "/maps | grep libmkldnn > /dev/null")
+    rc = os.system("cat /proc/" + str(pid) +
+                   "/maps | grep libmkldnn > /dev/null")
 
     if rc == 0:
         logging.info("MXNet is built/installed correctly with MKL-DNN")
     else:
         assert 0, "MXNet is built/installed incorrectly with MKL-DNN, please " \
-               "double check your build/install steps or environment " \
-               "variable settings"
+            "double check your build/install steps or environment " \
+            "variable settings"
+
+
+def test_mkldnn_model():
+    """
+    This test will run a sample model for couple of iterations.
+    """
+
+    import mxnet as mx
+    model = os.path.join(os.path.dirname(os.path.realpath(__file__)), "test_model.json")
 
 Review comment:
   could you move this file to a subdirectory like tests/python/cpu/data/test_mkldnn_ test_mkldnn_model_model1.json? (format is %FILENAME%_%TESTNAME%_model%NUMBER%.json)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services