You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/10/27 16:24:20 UTC
[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7160: Consider DS Regional field for MaxOriginConnections of Edge Caches
zrhoffman commented on code in PR #7160:
URL: https://github.com/apache/trafficcontrol/pull/7160#discussion_r1007114313
##########
lib/go-atscfg/headerrewritedotconfig_test.go:
##########
@@ -496,42 +407,91 @@ func TestGetAssignedMids(t *testing.T) {
ID: util.Ptr(2),
Status: util.Ptr(string(tc.CacheStatusReported)),
},
-
+ }
+ mids := []Server{
{
Cachegroup: util.Ptr("mid1"),
CDNName: util.Ptr("mycdn"),
HostName: util.Ptr("midCache1"),
ID: util.Ptr(3),
Status: util.Ptr(string(tc.CacheStatusReported)),
+ Type: tc.MidTypePrefix,
},
{
Cachegroup: util.Ptr("mid2"),
CDNName: util.Ptr("mycdn"),
HostName: util.Ptr("midCache2"),
ID: util.Ptr(4),
Status: util.Ptr(string(tc.CacheStatusReported)),
+ Type: tc.MidTypePrefix,
},
}
+ allServers := append(edges, mids...)
+ _ = allServers
- allDeliveryServices := []DeliveryService{{}, {}}
+ topology := tc.Topology{
+ Name: "mytopology",
+ Nodes: []tc.TopologyNode{
+ {
+ Cachegroup: "edge1",
+ Parents: []int{2},
+ },
+ {
+ Cachegroup: "edge2",
+ Parents: []int{2},
+ },
+ {
+ Cachegroup: "org1",
+ },
+ },
+ }
+ _ = topology
Review Comment:
Removed do-nothing lines in 3b25d1aeae
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org