You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/06/11 11:09:08 UTC
[GitHub] [pulsar] massakam opened a new pull request #4511: C++ client build
fails when USE_LOG4CXX is ON
massakam opened a new pull request #4511: C++ client build fails when USE_LOG4CXX is ON
URL: https://github.com/apache/pulsar/pull/4511
### Motivation
When I set `USE_LOG4CXX` to ON, C++ client build fails with the following error:
```
/tmp/apache-pulsar-2.3.2/pulsar-client-cpp/lib/ClientImpl.cc: In constructor ‘pulsar::ClientImpl::ClientImpl(const string&, const pulsar::ClientConfiguration&, bool)’:
/tmp/apache-pulsar-2.3.2/pulsar-client-cpp/lib/ClientImpl.cc:103:17: error: ‘Log4CxxLoggerFactory’ has not been declared
Log4CxxLoggerFactory::create(clientConfiguration_.getLogConfFilePath()));
```
This is because the header file `Log4CxxLogger.h` is not included in `ClientImpl.cc`.
### Modifications
Fixed `ClientImpl.cc` to include `Log4CxxLogger.h` only when `USE_LOG4CXX` is ON.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services