You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "jbonofre (via GitHub)" <gi...@apache.org> on 2025/04/29 12:58:29 UTC
[PR] Include quarkus-container-image and README in the binary distributions [polaris]
jbonofre opened a new pull request, #1493:
URL: https://github.com/apache/polaris/pull/1493
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain merged PR #1493:
URL: https://github.com/apache/polaris/pull/1493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2069427772
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
The `quarkus-container-image-docker` is actually not needed at compile time. There is no compile time dependency on it. This is verified by my test by just removing it. It's needed and only needed at runtime per my test. With that, marking it as `runtimeOnly` is reasonable. The only problem here is that the packaging task doesn't pick runtimeOnly dependencies, that's why I propose to customize a bit to include it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2069561693
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
`runtimeOnly` works, yes. If everybody thinks that's the best solution, I'm +1 on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2068430489
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
+ from("README.md")
Review Comment:
I added quick `README.md` in the distributions. That said, the documentation should be updated imho (I plan to do that in another PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2066882394
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
+ from("README.md")
Review Comment:
The current README isn't really helpful when it was shipped with binary package. The binary distribution package will need a readme to describe how it runs instead of how it builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2068449098
##########
quarkus/admin/distribution/README.md:
##########
@@ -0,0 +1,52 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Polaris Admin Tool
+
+The Polaris Admin Tool is a maintenance tool for performing administrative tasks on the Polaris server.
+
+## Prerequisites
+
+Polaris server requires a Java SE 20 or higher to run.
Review Comment:
Yes good catch. Let me update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2069547546
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
```
./gradlew \
:polaris-quarkus-server:assemble \
:polaris-quarkus-server:quarkusAppPartsBuild --rerun \
-Dquarkus.container-image.build=true
```
After remove the dependency(`// implementation("io.quarkus:quarkus-container-image-docker")`
), this command works and built a local docker image successfully. Which docker image build will failed
```
apache/polaris 0.11.0-beta-incubating-SNAPSHOT 7e1fc7ac2034 2 minutes ago 611MB
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2066874682
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
Would it work if we used runtimeOnly here?
```
implementation("io.quarkus:quarkus-container-image-docker")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2067096646
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
`runtimeOnly` wouldn't work. I tried the `buildOnly` approach btw, but it's too convoluted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2066874682
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
Does it work if we uses runtimeOnly here?
```
implementation("io.quarkus:quarkus-container-image-docker")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2066958201
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
+ from("README.md")
Review Comment:
Yeah. We can add a specific README for the binary distribution as we do for LICENSE/NOTICE. Maybe better if I do that in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #1493:
URL: https://github.com/apache/polaris/pull/1493#issuecomment-2839442921
Sorry to miss this one. Are we going to "pass $args to run.sh" in this PR? I'm OK if we made that change in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2067161227
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
With `runtimeOnly`, we need to customize the package task a bit like
```
from(configurations.runtimeOnly.get().filter {
it.name.contains("quarkus-container-image-docker")
}.map {
zipTree(it)
})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2069557610
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
Can you try this? It works for me.
```
runtimeOnly("io.quarkus:quarkus-container-image-docker")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1493:
URL: https://github.com/apache/polaris/pull/1493#issuecomment-2846310400
Thanks everyone for the review and the merge. I'm cherry picking on the release branch and move forward on the RC2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2069451314
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
`quarkus-container-image-docker` – as the name implies – is necessary to build Docker images for the project. If you remove it, there won't be any Docker images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2069862457
##########
quarkus/server/distribution/README.md:
##########
@@ -0,0 +1,36 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Apache Polaris - Server
+
+## Prerequisites
+
+Polaris server requires a Java SE 21 or higher to run.
+
+## Start the server
+
+In a command line, in the directory where you extracted the Polaris server archive, run the following command to start the server:
+
+```
+./run.sh
+```
Review Comment:
I added link to documentation in admin and server `README.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2068777148
##########
quarkus/admin/distribution/README.md:
##########
@@ -0,0 +1,52 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Polaris Admin Tool
+
+The Polaris Admin Tool is a maintenance tool for performing administrative tasks on the Polaris server.
+
+## Prerequisites
+
+Polaris server requires a Java SE 21 or higher to run.
Review Comment:
Good catch 😀 fixing 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2068592947
##########
quarkus/admin/distribution/README.md:
##########
@@ -0,0 +1,52 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Polaris Admin Tool
+
+The Polaris Admin Tool is a maintenance tool for performing administrative tasks on the Polaris server.
+
+## Prerequisites
+
+Polaris server requires a Java SE 21 or higher to run.
Review Comment:
Nit: should be "Polaris admin tool".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2069863488
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
For now, I would keep "simple". I propose to do another PR to improve that. Thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2068445921
##########
quarkus/admin/distribution/README.md:
##########
@@ -0,0 +1,52 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Polaris Admin Tool
+
+The Polaris Admin Tool is a maintenance tool for performing administrative tasks on the Polaris server.
+
+## Prerequisites
+
+Polaris server requires a Java SE 20 or higher to run.
Review Comment:
Nit: I think it's 21.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1493:
URL: https://github.com/apache/polaris/pull/1493#issuecomment-2839563382
@flyrain agree let me do that in another Pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1493:
URL: https://github.com/apache/polaris/pull/1493#issuecomment-2841597937
I updated this PR with:
- quick `README.md` in the distributions
- passing `$@` in the `run.sh` to be able to pass arguments (for admin distribution especially)
- update the `LICENSE` and `NOTICE` in the distributions to update version and add the new artifacts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2069552026
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
I do not see any image being created. You can double-check by changing the image name:
```
./gradlew \
:polaris-quarkus-server:assemble \
:polaris-quarkus-server:quarkusAppPartsBuild --rerun \
-Dquarkus.container-image.build=true -Dquarkus.container-image.name=foo
```
After that, I do not see any image named `foo` on my machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2069547546
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
```
./gradlew \
:polaris-quarkus-server:assemble \
:polaris-quarkus-server:quarkusAppPartsBuild --rerun \
-Dquarkus.container-image.build=true
```
After remove the dependency(`// implementation("io.quarkus:quarkus-container-image-docker")`
), this command works and built a local docker image successfully. Which docker image build will fail?
```
apache/polaris 0.11.0-beta-incubating-SNAPSHOT 7e1fc7ac2034 2 minutes ago 611MB
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1493:
URL: https://github.com/apache/polaris/pull/1493#issuecomment-2838769081
@flyrain @adutra as discussed on the mailing list
I'm also push a new commit to pass arg to `run.sh` in the admin distribution to be able to do `./run.sh --help` for instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2066882394
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
+ from("README.md")
Review Comment:
The current README isn't really helpful when it was shipped with binary package. The binary distribution package will need a readme to describe how it runs instead of how it builds. We may need to add another README file for binary distribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2066522832
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
That's not so easy with gradle for sure !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2066341088
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
FYI I tried to keep these jars excluded while still producing the Docker image during build, but my Gradle skills weren't enough 😆 – so I'm fine with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1493:
URL: https://github.com/apache/polaris/pull/1493#issuecomment-2838800159
By the way, I'm checking `LICENSE` and `NOTICE` content too as we have new artifacts in the distribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2066955409
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
The dependencies are actually already there but excluded. So it's more buildOnly more than runtimeOnly 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2067819649
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
That's not the problem: here we excluded the dependency because it was supposed to be a compile only dependency. But it's not. So we have to not exclude (whatever the scope is).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2069432288
##########
quarkus/server/distribution/README.md:
##########
@@ -0,0 +1,36 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Apache Polaris - Server
+
+## Prerequisites
+
+Polaris server requires a Java SE 21 or higher to run.
+
+## Start the server
+
+In a command line, in the directory where you extracted the Polaris server archive, run the following command to start the server:
+
+```
+./run.sh
+```
Review Comment:
It would be nice if we talked briefly about the root credential configuration. Maybe we just need to link this page, https://polaris.apache.org/in-dev/unreleased/configuring-polaris-for-production/. It's not a blocker. We can improve this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org