You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/03/17 14:27:11 UTC
[GitHub] [activemq-artemis] franz1981 opened a new pull request #3023:
ARTEMIS-2661 AMQP Journal loading is triggering reencode
franz1981 opened a new pull request #3023: ARTEMIS-2661 AMQP Journal loading is triggering reencode
URL: https://github.com/apache/activemq-artemis/pull/3023
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #3023: ARTEMIS-2661
AMQP Journal loading is triggering reencode
Posted by GitBox <gi...@apache.org>.
franz1981 commented on issue #3023: ARTEMIS-2661 AMQP Journal loading is triggering reencode
URL: https://github.com/apache/activemq-artemis/pull/3023#issuecomment-600103264
I'm now running some performance check to see if the fix is sound: in case I would create a follow-up PR to do something similar for the Core protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #3023: ARTEMIS-2661
AMQP Journal loading is triggering reencode
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3023: ARTEMIS-2661 AMQP Journal loading is triggering reencode
URL: https://github.com/apache/activemq-artemis/pull/3023
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request
#3023: ARTEMIS-2661 AMQP Journal loading is triggering reencode
Posted by GitBox <gi...@apache.org>.
franz1981 commented on a change in pull request #3023: ARTEMIS-2661 AMQP Journal loading is triggering reencode
URL: https://github.com/apache/activemq-artemis/pull/3023#discussion_r393734568
##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPStandardMessage.java
##########
@@ -162,14 +162,7 @@ public void reloadPersistence(ActiveMQBuffer record, CoreMessageObjectPools pool
// Message state is now that the underlying buffer is loaded, but the contents not yet scanned
resetMessageData();
modified = false;
- messageDataScanned = RELOAD_PERSISTENCE;
Review comment:
from now on until https://github.com/apache/activemq-artemis/pull/3023/files#diff-da09a729b09d53b14f4058f91bda710dL172: there was already a method on AMQPMessage that will call reencode, if needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request
#3023: ARTEMIS-2661 AMQP Journal loading is triggering reencode
Posted by GitBox <gi...@apache.org>.
franz1981 commented on a change in pull request #3023: ARTEMIS-2661 AMQP Journal loading is triggering reencode
URL: https://github.com/apache/activemq-artemis/pull/3023#discussion_r393734568
##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPStandardMessage.java
##########
@@ -162,14 +162,7 @@ public void reloadPersistence(ActiveMQBuffer record, CoreMessageObjectPools pool
// Message state is now that the underlying buffer is loaded, but the contents not yet scanned
resetMessageData();
modified = false;
- messageDataScanned = RELOAD_PERSISTENCE;
Review comment:
from now on: there was already a method on AMQPMessage that will call reencode, if needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull
request #3023: ARTEMIS-2661 AMQP Journal loading is triggering reencode
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3023: ARTEMIS-2661 AMQP Journal loading is triggering reencode
URL: https://github.com/apache/activemq-artemis/pull/3023#discussion_r393733836
##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPStandardMessage.java
##########
@@ -162,14 +162,7 @@ public void reloadPersistence(ActiveMQBuffer record, CoreMessageObjectPools pool
// Message state is now that the underlying buffer is loaded, but the contents not yet scanned
resetMessageData();
modified = false;
- messageDataScanned = RELOAD_PERSISTENCE;
Review comment:
really? that's the offending line? 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services