You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by jm...@apache.org on 2017/05/08 20:29:39 UTC
samza git commit: Disabled a few flaky tests and added corresponding
tickets to fix.
Repository: samza
Updated Branches:
refs/heads/master fa2f47559 -> ad41f9a7f
Disabled a few flaky tests and added corresponding tickets to fix.
Author: Prateek Maheshwari <pm...@linkedin.com>
Reviewers: Jacob Maes <jm...@linkedin.com>
Closes #171 from prateekm/disable-flaky-test
Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/ad41f9a7
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/ad41f9a7
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/ad41f9a7
Branch: refs/heads/master
Commit: ad41f9a7fdf30c8b1d91853cbdf70dbef664340e
Parents: fa2f475
Author: Prateek Maheshwari <pm...@linkedin.com>
Authored: Mon May 8 13:29:23 2017 -0700
Committer: Jacob Maes <jm...@linkedin.com>
Committed: Mon May 8 13:29:23 2017 -0700
----------------------------------------------------------------------
.../src/test/java/org/apache/samza/task/TestAsyncRunLoop.java | 5 +++--
.../test/scala/org/apache/samza/job/local/TestProcessJob.scala | 3 ++-
.../org/apache/samza/util/TestExponentialSleepStrategy.scala | 4 +++-
.../java/org/apache/samza/monitor/TestLocalStoreMonitor.java | 6 ++++--
4 files changed, 12 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/samza/blob/ad41f9a7/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java
----------------------------------------------------------------------
diff --git a/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java b/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java
index 2f233c0..1afc26a 100644
--- a/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java
+++ b/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java
@@ -52,11 +52,11 @@ import scala.collection.JavaConverters;
import static org.junit.Assert.assertEquals;
import static org.mockito.Matchers.anyLong;
import static org.mockito.Matchers.anyObject;
+import static org.mockito.Mockito.atLeastOnce;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
-import static org.mockito.Mockito.atLeastOnce;
// TODO(spvenkat) SAMZA-1183: Fix all commented out tests.
public class TestAsyncRunLoop {
@@ -341,7 +341,8 @@ public class TestAsyncRunLoop {
assertEquals(4, task1.windowCount);
}
- //@Test
+ // TODO fix in SAMZA-1183
+ // @Test
public void testCommitSingleTask() throws Exception {
CountDownLatch task0ProcessedMessagesLatch = new CountDownLatch(1);
CountDownLatch task1ProcessedMessagesLatch = new CountDownLatch(1);
http://git-wip-us.apache.org/repos/asf/samza/blob/ad41f9a7/samza-core/src/test/scala/org/apache/samza/job/local/TestProcessJob.scala
----------------------------------------------------------------------
diff --git a/samza-core/src/test/scala/org/apache/samza/job/local/TestProcessJob.scala b/samza-core/src/test/scala/org/apache/samza/job/local/TestProcessJob.scala
index d02a73c..58ecf99 100644
--- a/samza-core/src/test/scala/org/apache/samza/job/local/TestProcessJob.scala
+++ b/samza-core/src/test/scala/org/apache/samza/job/local/TestProcessJob.scala
@@ -39,7 +39,8 @@ class TestProcessJob {
job.waitForFinish(999999)
}
- @Test
+ // TODO: fix in SAMZA-1261
+ // @Test
def testProcessJobKillShouldWork {
val commandBuilder = new CommandBuilder {
override def buildCommand = "sleep 999999999"
http://git-wip-us.apache.org/repos/asf/samza/blob/ad41f9a7/samza-core/src/test/scala/org/apache/samza/util/TestExponentialSleepStrategy.scala
----------------------------------------------------------------------
diff --git a/samza-core/src/test/scala/org/apache/samza/util/TestExponentialSleepStrategy.scala b/samza-core/src/test/scala/org/apache/samza/util/TestExponentialSleepStrategy.scala
index b34003a..546f41b 100644
--- a/samza-core/src/test/scala/org/apache/samza/util/TestExponentialSleepStrategy.scala
+++ b/samza-core/src/test/scala/org/apache/samza/util/TestExponentialSleepStrategy.scala
@@ -130,7 +130,9 @@ class TestExponentialSleepStrategy {
exception
}
- @Test def testThreadInterruptInRetryLoop {
+ // TODO fix in SAMZA-1269
+ // @Test
+ def testThreadInterruptInRetryLoop {
val strategy = new ExponentialSleepStrategy
var iterations = 0
var loopObject: RetryLoop = null
http://git-wip-us.apache.org/repos/asf/samza/blob/ad41f9a7/samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java
----------------------------------------------------------------------
diff --git a/samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java b/samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java
index 2d1681c..2ad6935 100644
--- a/samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java
+++ b/samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java
@@ -97,7 +97,8 @@ public class TestLocalStoreMonitor {
}
}
- @Test
+ // TODO fix in SAMZA-1243
+ // @Test
public void shouldDeleteLocalTaskStoreWhenItHasNoOffsetFile() throws Exception {
localStoreMonitor.monitor();
assertTrue("Task store directory should not exist.", !taskStoreDir.exists());
@@ -147,7 +148,8 @@ public class TestLocalStoreMonitor {
assertEquals(0, localStoreMonitorMetrics.diskSpaceFreedInBytes.getCount());
}
- @Test
+ // TODO fix in SAMZA-1243
+ // @Test
public void shouldDeleteTaskStoreWhenTaskPreferredStoreIsNotLocalHost() throws Exception {
Task task = new Task("notLocalHost", "test-task", "0",
new ArrayList<>(), ImmutableList.of("test-store"));