You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/18 08:41:42 UTC
[GitHub] [flink] zoudan opened a new pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
zoudan opened a new pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This pull request makes it possible to skip dirty records in JsonRowDeserializationSchema.
## Brief change log
Add a configuration 'format.ignore-parse-errors' to indicate whether to ignore parse errors, false by default.
## Verifying this change
This change added tests and can be verified as follows:
JsonRowDeserializationSchemaTest.testInvalidJson
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151328780",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* 23df46401002fc6a2fd1800d76c069296c7339a3 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151328780) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "CANCELED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151328780",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* baf7d0242e8aacb3cd46154c864201dbb7315c86 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/151318299)
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* 23df46401002fc6a2fd1800d76c069296c7339a3 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151328780)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
Hash:68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:68fbf9d61e9c89eb323d7eb5cc08d18f9f852065
Hash:e47530dad8d30dcc2747a6fc01af8d964d74fdd6 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:e47530dad8d30dcc2747a6fc01af8d964d74fdd6
-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* e47530dad8d30dcc2747a6fc01af8d964d74fdd6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
Hash:68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:68fbf9d61e9c89eb323d7eb5cc08d18f9f852065
Hash:e47530dad8d30dcc2747a6fc01af8d964d74fdd6 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268 TriggerType:PUSH TriggerID:e47530dad8d30dcc2747a6fc01af8d964d74fdd6
Hash:e47530dad8d30dcc2747a6fc01af8d964d74fdd6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149414305 TriggerType:PUSH TriggerID:e47530dad8d30dcc2747a6fc01af8d964d74fdd6
-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* e47530dad8d30dcc2747a6fc01af8d964d74fdd6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149414305) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* e47530dad8d30dcc2747a6fc01af8d964d74fdd6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149414305) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268)
* ad80e395646ce696befcf296525970765f984394 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zoudan commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
zoudan commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r385151530
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -130,6 +135,9 @@ public Row deserialize(byte[] message) throws IOException {
final JsonNode root = objectMapper.readTree(message);
return (Row) runtimeConverter.convert(objectMapper, root);
} catch (Throwable t) {
+ if (ignoreParseErrors) {
+ return null;
+ }
Review comment:
When we set ignoreParseErrors=true and failOnMissingField=true, what is the expected behavior if we encounter an invalid json string like "DDD" ? Fail the job or swallow the exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zoudan commented on issue #11119: [FLINK-15396][json]
Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
zoudan commented on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-596962053
I agree, this will be much simpler and aligned with the behavior in csv. I will modify the code as you suggested, thank you so much for your help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* ad80e395646ce696befcf296525970765f984394 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150198304) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484)
* baf7d0242e8aacb3cd46154c864201dbb7315c86 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151328780",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151699886",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5902",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152131286",
"triggerID" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"triggerType" : "PUSH"
}, {
"hash" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6014",
"triggerID" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"triggerType" : "PUSH"
}, {
"hash" : "35d05f1120ea08875275f06f6379310e3d13c78b",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152623774",
"triggerID" : "35d05f1120ea08875275f06f6379310e3d13c78b",
"triggerType" : "PUSH"
}, {
"hash" : "35d05f1120ea08875275f06f6379310e3d13c78b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6129",
"triggerID" : "35d05f1120ea08875275f06f6379310e3d13c78b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* 35d05f1120ea08875275f06f6379310e3d13c78b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/152623774) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6129)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151328780",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151699886",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5902",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* bd34fbdfd99153eec91a9fca2c3eed537276426a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151699886) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5902)
* 3d042db7682646b6b7d6d709ead691ff074a70dc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r388792571
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -351,76 +377,131 @@ private DeserializationRuntimeConverter createFallbackConverter(Class<?> valueTy
}
}
+ private float convertToFloat(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return Float.parseFloat(jsonNode.asText().trim());
+ } catch (NumberFormatException e) {
+ throw createParseErrorException("Unable to deserialize float.", e);
Review comment:
If the whole json string is invalid, we can simply drop this record, instead emit a null Row. But for fields, we should use `null` if is invalid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* e47530dad8d30dcc2747a6fc01af8d964d74fdd6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149414305) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268)
* ad80e395646ce696befcf296525970765f984394 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150198304)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151328780",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151699886",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5902",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152131286",
"triggerID" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* bd34fbdfd99153eec91a9fca2c3eed537276426a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151699886) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5902)
* 3d042db7682646b6b7d6d709ead691ff074a70dc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/152131286)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r388735355
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -351,76 +377,131 @@ private DeserializationRuntimeConverter createFallbackConverter(Class<?> valueTy
}
}
+ private float convertToFloat(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return Float.parseFloat(jsonNode.asText().trim());
+ } catch (NumberFormatException e) {
+ throw createParseErrorException("Unable to deserialize float.", e);
Review comment:
If this is a parser exception, then we can just ignore exception here instead of propagating it, this will also be better for performance.
```java
} catch (NumberFormatException e) {
if (!ignoreParseErrors) {
throw e;
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong closed pull request #11119: [FLINK-15396][json]
Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151328780",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151699886",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* 23df46401002fc6a2fd1800d76c069296c7339a3 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151328780) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811)
* bd34fbdfd99153eec91a9fca2c3eed537276426a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151699886)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151328780",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* 23df46401002fc6a2fd1800d76c069296c7339a3 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151328780) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811)
* bd34fbdfd99153eec91a9fca2c3eed537276426a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11119: [FLINK-15396][json]
Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587344564
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 (Tue Feb 18 08:43:45 UTC 2020)
**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587344564
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ad80e395646ce696befcf296525970765f984394 (Fri Feb 28 21:49:24 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r387438612
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -351,76 +379,187 @@ private DeserializationRuntimeConverter createFallbackConverter(Class<?> valueTy
}
}
+ private boolean convertToBoolean(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return jsonNode.asBoolean();
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize boolean.", t);
+ }
+ }
+
+ private String convertToString(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return jsonNode.asText();
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize string.", t);
+ }
+ }
+
+ private int convertToInt(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return jsonNode.asInt();
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize int.", t);
+ }
+ }
+
+ private long convertToLong(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return jsonNode.asLong();
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize long.", t);
+ }
+ }
+
+ private double convertToDouble(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return jsonNode.asDouble();
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize double.", t);
+ }
+ }
+
+ private float convertToFloat(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return Float.parseFloat(jsonNode.asText().trim());
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize float.", t);
+ }
+ }
+
+ private short convertToShot(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return Short.parseShort(jsonNode.asText().trim());
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize short.", t);
+ }
+ }
+
+ private byte convertToByte(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return Byte.parseByte(jsonNode.asText().trim());
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize byte.", t);
+ }
+ }
+
+ private BigDecimal convertToBigDecimal(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return jsonNode.decimalValue();
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize BigDecimal.", t);
+ }
+ }
+
+ private BigInteger convertToBigInt(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return jsonNode.bigIntegerValue();
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize BigInteger.", t);
+ }
+ }
+
private LocalDate convertToLocalDate(ObjectMapper mapper, JsonNode jsonNode) {
- return ISO_LOCAL_DATE.parse(jsonNode.asText()).query(TemporalQueries.localDate());
+ try {
+ return ISO_LOCAL_DATE.parse(jsonNode.asText()).query(TemporalQueries.localDate());
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize local date.", t);
+ }
}
private Date convertToDate(ObjectMapper mapper, JsonNode jsonNode) {
- return Date.valueOf(convertToLocalDate(mapper, jsonNode));
+ try {
+ return Date.valueOf(convertToLocalDate(mapper, jsonNode));
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize date.", t);
+ }
}
private LocalDateTime convertToLocalDateTime(ObjectMapper mapper, JsonNode jsonNode) {
// according to RFC 3339 every date-time must have a timezone;
// until we have full timezone support, we only support UTC;
// users can parse their time as string as a workaround
- TemporalAccessor parsedTimestamp = RFC3339_TIMESTAMP_FORMAT.parse(jsonNode.asText());
+ try {
+ TemporalAccessor parsedTimestamp = RFC3339_TIMESTAMP_FORMAT.parse(jsonNode.asText());
- ZoneOffset zoneOffset = parsedTimestamp.query(TemporalQueries.offset());
+ ZoneOffset zoneOffset = parsedTimestamp.query(TemporalQueries.offset());
- if (zoneOffset != null && zoneOffset.getTotalSeconds() != 0) {
- throw new IllegalStateException(
- "Invalid timestamp format. Only a timestamp in UTC timezone is supported yet. " +
- "Format: yyyy-MM-dd'T'HH:mm:ss.SSS'Z'");
- }
+ if (zoneOffset != null && zoneOffset.getTotalSeconds() != 0) {
+ throw new IllegalStateException(
+ "Invalid timestamp format. Only a timestamp in UTC timezone is supported yet. " +
+ "Format: yyyy-MM-dd'T'HH:mm:ss.SSS'Z'");
+ }
- LocalTime localTime = parsedTimestamp.query(TemporalQueries.localTime());
- LocalDate localDate = parsedTimestamp.query(TemporalQueries.localDate());
+ LocalTime localTime = parsedTimestamp.query(TemporalQueries.localTime());
+ LocalDate localDate = parsedTimestamp.query(TemporalQueries.localDate());
- return LocalDateTime.of(localDate, localTime);
+ return LocalDateTime.of(localDate, localTime);
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize local date time.", t);
+ }
}
private Timestamp convertToTimestamp(ObjectMapper mapper, JsonNode jsonNode) {
- return Timestamp.valueOf(convertToLocalDateTime(mapper, jsonNode));
+ try {
+ return Timestamp.valueOf(convertToLocalDateTime(mapper, jsonNode));
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize timestamp.", t);
+ }
}
private LocalTime convertToLocalTime(ObjectMapper mapper, JsonNode jsonNode) {
// according to RFC 3339 every full-time must have a timezone;
// until we have full timezone support, we only support UTC;
// users can parse their time as string as a workaround
- TemporalAccessor parsedTime = RFC3339_TIME_FORMAT.parse(jsonNode.asText());
- ZoneOffset zoneOffset = parsedTime.query(TemporalQueries.offset());
- LocalTime localTime = parsedTime.query(TemporalQueries.localTime());
+ try {
+ TemporalAccessor parsedTime = RFC3339_TIME_FORMAT.parse(jsonNode.asText());
- if (zoneOffset != null && zoneOffset.getTotalSeconds() != 0 || localTime.getNano() != 0) {
- throw new IllegalStateException(
- "Invalid time format. Only a time in UTC timezone without milliseconds is supported yet.");
- }
+ ZoneOffset zoneOffset = parsedTime.query(TemporalQueries.offset());
+ LocalTime localTime = parsedTime.query(TemporalQueries.localTime());
- return localTime;
+ if (zoneOffset != null && zoneOffset.getTotalSeconds() != 0 || localTime.getNano() != 0) {
+ throw new IllegalStateException(
+ "Invalid time format. Only a time in UTC timezone without milliseconds is supported yet.");
+ }
+
+ return localTime;
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize local time.", t);
+ }
}
private Time convertToTime(ObjectMapper mapper, JsonNode jsonNode) {
- return Time.valueOf(convertToLocalTime(mapper, jsonNode));
+ try {
+ return Time.valueOf(convertToLocalTime(mapper, jsonNode));
+ } catch (Throwable t) {
+ throw new ParseErrorException("Unable to deserialize time.", t);
+ }
}
private DeserializationRuntimeConverter assembleRowConverter(
String[] fieldNames,
List<DeserializationRuntimeConverter> fieldConverters) {
- return (mapper, jsonNode) -> {
- ObjectNode node = (ObjectNode) jsonNode;
-
- int arity = fieldNames.length;
- Row row = new Row(arity);
- for (int i = 0; i < arity; i++) {
- String fieldName = fieldNames[i];
- JsonNode field = node.get(fieldName);
- Object convertField = convertField(mapper, fieldConverters.get(i), fieldName, field);
- row.setField(i, convertField);
+ try {
+ return (mapper, jsonNode) -> {
+ ObjectNode node = (ObjectNode) jsonNode;
+ int arity = fieldNames.length;
+ Row row = new Row(arity);
+ for (int i = 0; i < arity; i++) {
+ String fieldName = fieldNames[i];
+ JsonNode field = node.get(fieldName);
+ Object convertField = convertField(mapper, fieldConverters.get(i), fieldName, field);
+ row.setField(i, convertField);
+ }
+
+ return row;
+ };
+ } catch (Throwable t) {
Review comment:
if the exception is from inner field, the exception will duplicate.
or we just check jsonNode is a valid ObjectNode, and throw exception if it's not? instead of try all process of the conversion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
Hash:68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:68fbf9d61e9c89eb323d7eb5cc08d18f9f852065
Hash:e47530dad8d30dcc2747a6fc01af8d964d74fdd6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268 TriggerType:PUSH TriggerID:e47530dad8d30dcc2747a6fc01af8d964d74fdd6
Hash:e47530dad8d30dcc2747a6fc01af8d964d74fdd6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149414305 TriggerType:PUSH TriggerID:e47530dad8d30dcc2747a6fc01af8d964d74fdd6
-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* e47530dad8d30dcc2747a6fc01af8d964d74fdd6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149414305) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on issue #11119: [FLINK-15396][json]
Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-596949777
Hi @zoudan , I think the added test is too simple and can't cover the changes. I propose to add some test data and iterate the test data to verify the exception and error suppression.
I also tried that in my local branch and find some missing part and some code can be further improved.
I also re-thought the exception catch logic, I think we can just catch the exception in `wrapIntoNullableConverter`, all the exception happened in conversion can be regarded as parse errors. That will be much simpler.
Regarding to the behavior of `failOnMissingField` and `ignoreParseErrors` are both enabled, I find csv format treat missing field as parse errors too. But it's a little weird the missing field error is not reported when `failOnMissingField` is true. So I would like to propose to disable this case for now, i.e. `failOnMissingField` and `ignoreParseErrors` is unsupported currently. We can revisit this and introduce the behavior in the future.
I have a PoC branch for the above things: https://github.com/wuchong/flink/tree/pull/11119
What do you think about that? @zoudan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zoudan commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
zoudan commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r385151530
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -130,6 +135,9 @@ public Row deserialize(byte[] message) throws IOException {
final JsonNode root = objectMapper.readTree(message);
return (Row) runtimeConverter.convert(objectMapper, root);
} catch (Throwable t) {
+ if (ignoreParseErrors) {
+ return null;
+ }
Review comment:
When we set ignoreParseErrors=true and failOnMissingField=true, what is the expected behavior if we encounter an invalid json string like "DDD" ? Fail the job or swallow the exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151328780",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* 23df46401002fc6a2fd1800d76c069296c7339a3 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151328780) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151328780",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151699886",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5902",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* bd34fbdfd99153eec91a9fca2c3eed537276426a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/151699886) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5902)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* e47530dad8d30dcc2747a6fc01af8d964d74fdd6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149414305) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268)
* ad80e395646ce696befcf296525970765f984394 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150198304) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151328780",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151699886",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5902",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152131286",
"triggerID" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"triggerType" : "PUSH"
}, {
"hash" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6014",
"triggerID" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"triggerType" : "PUSH"
}, {
"hash" : "35d05f1120ea08875275f06f6379310e3d13c78b",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152623774",
"triggerID" : "35d05f1120ea08875275f06f6379310e3d13c78b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* 3d042db7682646b6b7d6d709ead691ff074a70dc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152131286) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6014)
* 35d05f1120ea08875275f06f6379310e3d13c78b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/152623774)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zoudan commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
zoudan commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r388795018
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -351,76 +377,131 @@ private DeserializationRuntimeConverter createFallbackConverter(Class<?> valueTy
}
}
+ private float convertToFloat(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return Float.parseFloat(jsonNode.asText().trim());
+ } catch (NumberFormatException e) {
+ throw createParseErrorException("Unable to deserialize float.", e);
Review comment:
We could not drop the record for invalid json string, as there must be a return value for JsonRowDeserializationSchema.deserialize.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* ad80e395646ce696befcf296525970765f984394 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150198304) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r382900595
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -184,8 +199,18 @@ public Builder failOnMissingField() {
return this;
}
+ /**
+ * Configures schema to fail when parse json failed.
Review comment:
parse -> parsing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151328780",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151699886",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5902",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152131286",
"triggerID" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"triggerType" : "PUSH"
}, {
"hash" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6014",
"triggerID" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"triggerType" : "PUSH"
}, {
"hash" : "35d05f1120ea08875275f06f6379310e3d13c78b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "35d05f1120ea08875275f06f6379310e3d13c78b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* 3d042db7682646b6b7d6d709ead691ff074a70dc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152131286) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6014)
* 35d05f1120ea08875275f06f6379310e3d13c78b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #11119: [FLINK-15396][json]
Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-590068781
LGTM. +1 for merging.
cc @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* ad80e395646ce696befcf296525970765f984394 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150198304) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484)
* baf7d0242e8aacb3cd46154c864201dbb7315c86 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151318299)
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r386253447
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -130,6 +135,9 @@ public Row deserialize(byte[] message) throws IOException {
final JsonNode root = objectMapper.readTree(message);
return (Row) runtimeConverter.convert(objectMapper, root);
} catch (Throwable t) {
+ if (ignoreParseErrors) {
+ return null;
+ }
Review comment:
We have two parsing error actually:
- `objectMapper.readTree` will throw parsing error when data is not a valid json, it will throw `IOException`
- converters will throw parsing error when data cannot converted to specified type, we can make converters throw a custom exception
So we can check exceptions for just these two types of exception, and apply ignore parse errors strategy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zoudan commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
zoudan commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r388753743
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -351,76 +377,131 @@ private DeserializationRuntimeConverter createFallbackConverter(Class<?> valueTy
}
}
+ private float convertToFloat(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return Float.parseFloat(jsonNode.asText().trim());
+ } catch (NumberFormatException e) {
+ throw createParseErrorException("Unable to deserialize float.", e);
Review comment:
What result should we return if we just ignore the parse exception here? It seems that throwing an exception may be a good choice. What do you think? @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r382900561
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -88,14 +88,25 @@
private DeserializationRuntimeConverter runtimeConverter;
+ /** Flag indicating whether to ignore invalid fields/rows (default: throw an exception). */
+ private final boolean ignoreParseErrors;
+
private JsonRowDeserializationSchema(
TypeInformation<Row> typeInfo,
- boolean failOnMissingField) {
+ boolean failOnMissingField,
+ boolean ignoreParseErrors) {
checkNotNull(typeInfo, "Type information");
checkArgument(typeInfo instanceof RowTypeInfo, "Only RowTypeInfo is supported");
this.typeInfo = (RowTypeInfo) typeInfo;
this.failOnMissingField = failOnMissingField;
this.runtimeConverter = createConverter(this.typeInfo);
+ this.ignoreParseErrors = ignoreParseErrors;
+ }
+
+ private JsonRowDeserializationSchema(
Review comment:
seems that we don't need this constructor any more ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* ad80e395646ce696befcf296525970765f984394 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150198304) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484)
* baf7d0242e8aacb3cd46154c864201dbb7315c86 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151318299)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r388848213
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -351,76 +377,131 @@ private DeserializationRuntimeConverter createFallbackConverter(Class<?> valueTy
}
}
+ private float convertToFloat(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return Float.parseFloat(jsonNode.asText().trim());
+ } catch (NumberFormatException e) {
+ throw createParseErrorException("Unable to deserialize float.", e);
Review comment:
Yes, you are right. That will be resolved in new DeserializationSchema in the future. Let's return `null` for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zoudan commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
zoudan commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r388758824
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -351,76 +377,131 @@ private DeserializationRuntimeConverter createFallbackConverter(Class<?> valueTy
}
}
+ private float convertToFloat(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return Float.parseFloat(jsonNode.asText().trim());
+ } catch (NumberFormatException e) {
+ throw createParseErrorException("Unable to deserialize float.", e);
Review comment:
Just to confirm, we return null fields for invalid fields and return null rows for invalid json string when 'ignoreParseErrors' is 'ture'. Am I right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* e47530dad8d30dcc2747a6fc01af8d964d74fdd6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149414305) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268)
* ad80e395646ce696befcf296525970765f984394 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150198304) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zoudan commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
zoudan commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r387498390
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -351,76 +379,187 @@ private DeserializationRuntimeConverter createFallbackConverter(Class<?> valueTy
}
}
+ private boolean convertToBoolean(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return jsonNode.asBoolean();
Review comment:
I find that other JsonNodes except BooleanNode will return a default 'false' when we call 'asBoolean()' and not throw an exception. Other JsonNodes have similar behaviors. I will modify this PR as we do not need to catch exceptions when parsing JsonNode like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r385117397
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -130,6 +135,9 @@ public Row deserialize(byte[] message) throws IOException {
final JsonNode root = objectMapper.readTree(message);
return (Row) runtimeConverter.convert(objectMapper, root);
} catch (Throwable t) {
+ if (ignoreParseErrors) {
+ return null;
+ }
Review comment:
It ignores all exceptions including the exception which may be not a parsing errors. For example, if `ignoreParseErrors=true` and `failOnMissingField=true`, the missing field exception will be swallowed.
I think we should check the exception in every converters to have a fine-grained exception ignoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#discussion_r388754235
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java
##########
@@ -351,76 +377,131 @@ private DeserializationRuntimeConverter createFallbackConverter(Class<?> valueTy
}
}
+ private float convertToFloat(ObjectMapper mapper, JsonNode jsonNode) {
+ try {
+ return Float.parseFloat(jsonNode.asText().trim());
+ } catch (NumberFormatException e) {
+ throw createParseErrorException("Unable to deserialize float.", e);
Review comment:
Yes. We should return null if errors is ignored. We can wrap this logic into a method to reduce duplicate code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151328780",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151699886",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5902",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152131286",
"triggerID" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"triggerType" : "PUSH"
}, {
"hash" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6014",
"triggerID" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"triggerType" : "PUSH"
}, {
"hash" : "35d05f1120ea08875275f06f6379310e3d13c78b",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152623774",
"triggerID" : "35d05f1120ea08875275f06f6379310e3d13c78b",
"triggerType" : "PUSH"
}, {
"hash" : "35d05f1120ea08875275f06f6379310e3d13c78b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6129",
"triggerID" : "35d05f1120ea08875275f06f6379310e3d13c78b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* 35d05f1120ea08875275f06f6379310e3d13c78b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/152623774) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6129)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151328780",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151699886",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5902",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* bd34fbdfd99153eec91a9fca2c3eed537276426a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151699886) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5902)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151328780",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5811",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151699886",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5902",
"triggerID" : "bd34fbdfd99153eec91a9fca2c3eed537276426a",
"triggerType" : "PUSH"
}, {
"hash" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152131286",
"triggerID" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"triggerType" : "PUSH"
}, {
"hash" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6014",
"triggerID" : "3d042db7682646b6b7d6d709ead691ff074a70dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* 3d042db7682646b6b7d6d709ead691ff074a70dc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152131286) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6014)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11119: [FLINK-15396][json]
Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
Hash:68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:68fbf9d61e9c89eb323d7eb5cc08d18f9f852065
-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150198304",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "ad80e395646ce696befcf296525970765f984394",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5484",
"triggerID" : "ad80e395646ce696befcf296525970765f984394",
"triggerType" : "PUSH"
}, {
"hash" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"status" : "CANCELED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151318299",
"triggerID" : "baf7d0242e8aacb3cd46154c864201dbb7315c86",
"triggerType" : "PUSH"
}, {
"hash" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ecd2ee1b734a3dc868d20c8c2532447071f0233",
"triggerType" : "PUSH"
}, {
"hash" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "23df46401002fc6a2fd1800d76c069296c7339a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* baf7d0242e8aacb3cd46154c864201dbb7315c86 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/151318299)
* 1ecd2ee1b734a3dc868d20c8c2532447071f0233 UNKNOWN
* 23df46401002fc6a2fd1800d76c069296c7339a3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11119:
[FLINK-15396][json] Support to ignore parse errors for JSON format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format
URL: https://github.com/apache/flink/pull/11119#issuecomment-587365636
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68fbf9d61e9c89eb323d7eb5cc08d18f9f852065",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
}, {
"hash" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149414305",
"triggerID" : "e47530dad8d30dcc2747a6fc01af8d964d74fdd6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68fbf9d61e9c89eb323d7eb5cc08d18f9f852065 UNKNOWN
* e47530dad8d30dcc2747a6fc01af8d964d74fdd6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149414305) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5268)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services