You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by vrozov <gi...@git.apache.org> on 2017/11/10 02:36:15 UTC
[GitHub] drill pull request #1031: DRILL-5917: Ban org.json:json library in Drill
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1031
DRILL-5917: Ban org.json:json library in Drill
@arina-ielchiieva Please review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/drill DRILL-5917
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1031.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1031
----
commit 525989d8603954bfd5e12a680acde7ac00e26300
Author: Vlad Rozov <vr...@apache.org>
Date: 2017-11-08T01:07:38Z
DRILL-5917: Ban org.json:json library in Drill
----
---
[GitHub] drill issue #1031: DRILL-5917: Ban org.json:json library in Drill
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1031
rebased to upstream/master and squashed commits.
---
[GitHub] drill issue #1031: DRILL-5917: Ban org.json:json library in Drill
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1031
@arina-ielchiieva Please test
---
[GitHub] drill issue #1031: DRILL-5917: Ban org.json:json library in Drill
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1031
@arina-ielchiieva Please attach the full log to JIRA.
---
[GitHub] drill issue #1031: DRILL-5917: Ban org.json:json library in Drill
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1031
Test cluster is down for the weekend. You can test it locally, just run {{mvn clean install -Pmapr}}.
---
[GitHub] drill issue #1031: DRILL-5917: Ban org.json:json library in Drill
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1031
@arina-ielchiieva Please test with the latest commit. I changed mapr version back to 5.2.1, note that 2.7.0-mapr-1707 is compiled with 5.2.2
---
[GitHub] drill issue #1031: DRILL-5917: Ban org.json:json library in Drill
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1031
@vrozov when I have deployed Drill with your changes on test cluster, Drill start up failed with the following error:
```
2017-11-13 01:30:12,3367 ERROR JniCommon fs/client/fileclient/cc/jni_MapRClient.cc:616 Thread: 26996 Mismatch found for java and native libraries java build version 5.2.2.44680GA, native build version 5.2.2.44680.GA java patch vserion $Id: mapr-version: 5.2.2.44680GA 44680:b0ba7dcefd80b9aaf39f05f3, native patch version $Id: mapr-version: 5.2.2.44680.GA 44680:b0ba7dcefd80b9aaf39f05f
2017-11-13 01:30:12,3368 ERROR JniCommon fs/client/fileclient/cc/jni_MapRClient.cc:626 Thread: 26996 Client initialization failed.
Exception in thread "main" org.apache.drill.exec.exception.DrillbitStartupException: Failure during initial startup of Drillbit.
at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:353)
at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:323)
at org.apache.drill.exec.server.Drillbit.main(Drillbit.java:319)
Caused by: org.apache.drill.common.exceptions.DrillRuntimeException: Error during udf area creation [/user/root/drill/udf/registry] on file system [maprfs:///]
at org.apache.drill.common.exceptions.DrillRuntimeException.format(DrillRuntimeException.java:49)
at org.apache.drill.exec.expr.fn.registry.RemoteFunctionRegistry.createArea(RemoteFunctionRegistry.java:277)
at org.apache.drill.exec.expr.fn.registry.RemoteFunctionRegistry.prepareAreas(RemoteFunctionRegistry.java:234)
at org.apache.drill.exec.expr.fn.registry.RemoteFunctionRegistry.init(RemoteFunctionRegistry.java:105)
at org.apache.drill.exec.server.Drillbit.run(Drillbit.java:167)
at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:349)
... 2 more
Caused by: java.io.IOException: Could not create FileClient
at com.mapr.fs.MapRFileSystem.lookupClient(MapRFileSystem.java:626)
at com.mapr.fs.MapRFileSystem.lookupClient(MapRFileSystem.java:679)
at com.mapr.fs.MapRFileSystem.makeDir(MapRFileSystem.java:1239)
at com.mapr.fs.MapRFileSystem.mkdirs(MapRFileSystem.java:1276)
at org.apache.hadoop.fs.FileSystem.mkdirs(FileSystem.java:1917)
at org.apache.drill.exec.expr.fn.registry.RemoteFunctionRegistry.createArea(RemoteFunctionRegistry.java:254)
... 6 more
```
Without your changes start up was successful.
---
[GitHub] drill pull request #1031: DRILL-5917: Ban org.json:json library in Drill
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1031
---
[GitHub] drill issue #1031: DRILL-5917: Ban org.json:json library in Drill
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1031
I already tested mapr and default profile locally. Once test pass on your cluster, let me know and I'll squash commits.
---
[GitHub] drill issue #1031: DRILL-5917: Ban org.json:json library in Drill
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1031
@vrozov I have posted all content of drillbit.out. drillbit.log just had information that could not create remote function registry directory.
---
[GitHub] drill issue #1031: DRILL-5917: Ban org.json:json library in Drill
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1031
I see some functional test failures but I don't think they are related, it might be that your branch is not based on the latest master, so +1, LGTM.
@vrozov thanks for making the changes!
---