You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@allura.apache.org by gc...@apache.org on 2023/03/06 18:47:05 UTC

[allura] 01/04: [#8502] added ruff as a dependency and updates command in test_syntax

This is an automated email from the ASF dual-hosted git repository.

gcruz pushed a commit to branch gc/8502
in repository https://gitbox.apache.org/repos/asf/allura.git

commit c06cce9df6afd6e3d66b8682814ee9f209e2f65c
Author: Guillermo Cruz <gu...@slashdotmedia.com>
AuthorDate: Sun Mar 5 18:29:34 2023 -0600

    [#8502] added ruff as a dependency and updates command in test_syntax
---
 AlluraTest/alluratest/test_syntax.py | 7 ++++---
 requirements.in                      | 3 ++-
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/AlluraTest/alluratest/test_syntax.py b/AlluraTest/alluratest/test_syntax.py
index a7cdc5490..21ffd869e 100644
--- a/AlluraTest/alluratest/test_syntax.py
+++ b/AlluraTest/alluratest/test_syntax.py
@@ -86,10 +86,11 @@ def run_pyflakes(files):
         '__version__',
     ]
     files = [f for f in files if '/migrations/' not in f]
-    cmd = "pyflakes " + ' '.join(files) + " | grep -v '" + "' | grep -v '".join(skips) + "'"
+    cmd = "ruff check " + ' '.join(files) + " | grep -v '" + "' | grep -v '".join(skips) + "'"
+    #print("CMD", cmd)
     if run(cmd) != 1:
         # print 'Command was: %s' % cmd
-        raise Exception('pyflakes failure, see stdout')
+        raise Exception('ruff failure, see stdout')
 
 
 class TestLinters:
@@ -97,7 +98,7 @@ class TestLinters:
     pass
 
 
-# Dynamically generate many test methods, to run pylint & pyflakes commands in separate batches
+# Dynamically generate many test methods, to run pylint & ruff commands in separate batches
 # Can't use http://nose.readthedocs.io/en/latest/writing_tests.html#test-generators because nose doesn't run
 # those in parallel
 def create_many_lint_methods():
diff --git a/requirements.in b/requirements.in
index 303d81b28..68685bc65 100644
--- a/requirements.in
+++ b/requirements.in
@@ -49,7 +49,7 @@ werkzeug
 wrapt
 # testing
 mock
-pyflakes
+#pyflakes
 #pylint -- disabled due to [#8346]  (also requires diff versions on py2 vs 3, including transitive deps which gets tricky with pip-compile)
 testfixtures
 WebTest
@@ -59,3 +59,4 @@ pytest-sugar
 
 # deployment
 gunicorn
+ruff
\ No newline at end of file