You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/09/19 20:03:11 UTC
Review Request 25840: Perform a deep copy of mutable thrift objects in
generated FROM_BUILDER functions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25840/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-729
https://issues.apache.org/jira/browse/AURORA-729
Repository: aurora
Description
-------
At one point, the constructor _did_ detach objects, but this hole remained when buildNoCopy was introduced.
Diffs
-----
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 95fbd8950350786582dcd9dbfbe8b56f9f866700
src/test/java/org/apache/aurora/scheduler/storage/entities/IHostAttributesTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/25840/diff/
Testing
-------
./gradlew build -Pq
Thanks,
Bill Farner
Re: Review Request 25840: Perform a deep copy of mutable thrift
objects in generated FROM_BUILDER functions.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25840/#review53973
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 19, 2014, 6:03 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25840/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2014, 6:03 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-729
> https://issues.apache.org/jira/browse/AURORA-729
>
>
> Repository: aurora
>
>
> Description
> -------
>
> At one point, the constructor _did_ detach objects, but this hole remained when buildNoCopy was introduced.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 95fbd8950350786582dcd9dbfbe8b56f9f866700
> src/test/java/org/apache/aurora/scheduler/storage/entities/IHostAttributesTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25840/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Bill Farner
>
>