You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/05/25 14:14:03 UTC
[commons-jexl] branch master updated: These type casts are not
needed.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jexl.git
The following commit(s) were added to refs/heads/master by this push:
new a90b696 These type casts are not needed.
a90b696 is described below
commit a90b69652be2d2d538e4aea175468f41cd455f20
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon May 25 10:13:58 2020 -0400
These type casts are not needed.
---
.../java/org/apache/commons/jexl3/internal/LexicalFrame.java | 2 +-
.../org/apache/commons/jexl3/internal/TemplateDebugger.java | 2 +-
.../jexl3/internal/introspection/ConstructorMethod.java | 4 ++--
src/test/java/org/apache/commons/jexl3/ArithmeticTest.java | 2 +-
src/test/java/org/apache/commons/jexl3/JXLTTest.java | 8 ++++----
src/test/java/org/apache/commons/jexl3/LambdaTest.java | 2 +-
src/test/java/org/apache/commons/jexl3/SideEffectTest.java | 12 ++++++------
7 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/src/main/java/org/apache/commons/jexl3/internal/LexicalFrame.java b/src/main/java/org/apache/commons/jexl3/internal/LexicalFrame.java
index 54c570b..22eefde 100644
--- a/src/main/java/org/apache/commons/jexl3/internal/LexicalFrame.java
+++ b/src/main/java/org/apache/commons/jexl3/internal/LexicalFrame.java
@@ -119,7 +119,7 @@ public class LexicalFrame extends LexicalScope {
frame.set(symbol, value);
}
}
- return (LexicalFrame) previous;
+ return previous;
}
}
diff --git a/src/main/java/org/apache/commons/jexl3/internal/TemplateDebugger.java b/src/main/java/org/apache/commons/jexl3/internal/TemplateDebugger.java
index d5791f9..aa45923 100644
--- a/src/main/java/org/apache/commons/jexl3/internal/TemplateDebugger.java
+++ b/src/main/java/org/apache/commons/jexl3/internal/TemplateDebugger.java
@@ -106,7 +106,7 @@ public class TemplateDebugger extends Debugger {
protected Object visit(ASTBlock node, Object data) {
// if not really a template, must use super impl
if (exprs == null) {
- return super.visit((ASTBlock) node, data);
+ return super.visit(node, data);
}
// open the block
builder.append('{');
diff --git a/src/main/java/org/apache/commons/jexl3/internal/introspection/ConstructorMethod.java b/src/main/java/org/apache/commons/jexl3/internal/introspection/ConstructorMethod.java
index e787b4b..0d9a99b 100644
--- a/src/main/java/org/apache/commons/jexl3/internal/introspection/ConstructorMethod.java
+++ b/src/main/java/org/apache/commons/jexl3/internal/introspection/ConstructorMethod.java
@@ -68,7 +68,7 @@ public final class ConstructorMethod implements JexlMethod {
boolean invoke = true;
if (obj != null) {
if (obj instanceof Class<?>) {
- invoke = ctorClass.equals((Class<?>) obj);
+ invoke = ctorClass.equals(obj);
} else {
invoke = ctorClass.getName().equals(obj.toString());
}
@@ -86,7 +86,7 @@ public final class ConstructorMethod implements JexlMethod {
boolean invoke = true;
if (obj != null) {
if (obj instanceof Class<?>) {
- invoke = ctorClass.equals((Class<?>) obj);
+ invoke = ctorClass.equals(obj);
} else {
invoke = ctorClass.getName().equals(obj.toString());
}
diff --git a/src/test/java/org/apache/commons/jexl3/ArithmeticTest.java b/src/test/java/org/apache/commons/jexl3/ArithmeticTest.java
index 3c6be95..c1e7b88 100644
--- a/src/test/java/org/apache/commons/jexl3/ArithmeticTest.java
+++ b/src/test/java/org/apache/commons/jexl3/ArithmeticTest.java
@@ -320,7 +320,7 @@ public class ArithmeticTest extends JexlTestCase {
String expr = "2.3*SO/100";
Object evaluate = JEXL.createExpression(expr).evaluate(jc);
- Assert.assertEquals(sevendot475, (BigDecimal) evaluate);
+ Assert.assertEquals(sevendot475, evaluate);
}
// JEXL-24: big integers and big decimals
diff --git a/src/test/java/org/apache/commons/jexl3/JXLTTest.java b/src/test/java/org/apache/commons/jexl3/JXLTTest.java
index ceba48f..a2969b7 100644
--- a/src/test/java/org/apache/commons/jexl3/JXLTTest.java
+++ b/src/test/java/org/apache/commons/jexl3/JXLTTest.java
@@ -98,7 +98,7 @@ public class JXLTTest extends JexlTestCase {
}
private static String refactor(TemplateDebugger td, JxltEngine.Template ts) {
- boolean dbg = td.debug((TemplateScript)ts);
+ boolean dbg = td.debug(ts);
if (dbg) {
return td.toString();
} else {
@@ -580,7 +580,7 @@ public class JXLTTest extends JexlTestCase {
Assert.assertNotNull(dstr);
TemplateDebugger td = new TemplateDebugger();
- String refactored = refactor(td, (TemplateScript) t);
+ String refactored = refactor(td, t);
Assert.assertNotNull(refactored);
Assert.assertEquals(test42, refactored);
}
@@ -647,7 +647,7 @@ public class JXLTTest extends JexlTestCase {
Assert.assertEquals(ctl, output);
TemplateDebugger td = new TemplateDebugger();
- String refactored = refactor(td, (TemplateScript) t);
+ String refactored = refactor(td, t);
Assert.assertNotNull(refactored);
Assert.assertEquals(rpt, refactored);
}
@@ -707,7 +707,7 @@ public class JXLTTest extends JexlTestCase {
Assert.assertTrue(output.indexOf("45") > 0);
TemplateDebugger td = new TemplateDebugger();
- String xxx = refactor(td, (TemplateScript) t);
+ String xxx = refactor(td, t);
Assert.assertNotNull(xxx);
Assert.assertEquals(rpt, xxx);
}
diff --git a/src/test/java/org/apache/commons/jexl3/LambdaTest.java b/src/test/java/org/apache/commons/jexl3/LambdaTest.java
index c24cfd1..025704b 100644
--- a/src/test/java/org/apache/commons/jexl3/LambdaTest.java
+++ b/src/test/java/org/apache/commons/jexl3/LambdaTest.java
@@ -182,7 +182,7 @@ public class LambdaTest extends JexlTestCase {
hvars = s15.getVariables();
Assert.assertEquals(1, hvars.size());
// evidence this is not (strictly) a local since it inherited a captured value
- result = ((JexlScript) s15).execute(ctx, 27);
+ result = s15.execute(ctx, 27);
Assert.assertEquals(42, result);
}
diff --git a/src/test/java/org/apache/commons/jexl3/SideEffectTest.java b/src/test/java/org/apache/commons/jexl3/SideEffectTest.java
index 55f5ac0..3443216 100644
--- a/src/test/java/org/apache/commons/jexl3/SideEffectTest.java
+++ b/src/test/java/org/apache/commons/jexl3/SideEffectTest.java
@@ -288,13 +288,13 @@ public class SideEffectTest extends JexlTestCase {
Assert.assertEquals(foo.value, i41 % 2);
foo.value = i41;
asserter.assertExpression("foo.value &= 3", (long) (i41 & 3));
- Assert.assertEquals(foo.value, (long)(i41 & 3));
+ Assert.assertEquals(foo.value, i41 & 3);
foo.value = i41;
asserter.assertExpression("foo.value |= 2", (long)(i41 | 2));
- Assert.assertEquals(foo.value, (long)(i41 | 2));
+ Assert.assertEquals(foo.value, i41 | 2);
foo.value = i41;
asserter.assertExpression("foo.value ^= 2", (long)(i41 ^ 2));
- Assert.assertEquals(foo.value, (long)(i41 ^ 2));
+ Assert.assertEquals(foo.value, i41 ^ 2);
}
@Test
@@ -322,13 +322,13 @@ public class SideEffectTest extends JexlTestCase {
Assert.assertEquals(foo.value, i41 % 2);
foo.value = i41;
asserter.assertExpression("foo.bar[0] &= 3", (long) (i41 & 3));
- Assert.assertEquals(foo.value, (long)(i41 & 3));
+ Assert.assertEquals(foo.value, i41 & 3);
foo.value = i41;
asserter.assertExpression("foo.bar[0] |= 2", (long)(i41 | 2));
- Assert.assertEquals(foo.value, (long)(i41 | 2));
+ Assert.assertEquals(foo.value, i41 | 2);
foo.value = i41;
asserter.assertExpression("foo.bar[0] ^= 2", (long)(i41 ^ 2));
- Assert.assertEquals(foo.value, (long)(i41 ^ 2));
+ Assert.assertEquals(foo.value, i41 ^ 2);
}
@Test