You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2005/10/06 01:37:57 UTC
svn commit: r295141 - in /httpd/httpd/trunk/server: core.c protocol.c
request.c
Author: wrowe
Date: Wed Oct 5 16:37:53 2005
New Revision: 295141
URL: http://svn.apache.org/viewcvs?rev=295141&view=rev
Log:
Pay close attention to core_create_req() ... and note
that not one other member of the r->vars is initialized
herein. Move this initialization elsewhere.
(If this is the 'default' - it really aught to be the
zero value, for that matter).
Modified:
httpd/httpd/trunk/server/core.c
httpd/httpd/trunk/server/protocol.c
httpd/httpd/trunk/server/request.c
Modified: httpd/httpd/trunk/server/core.c
URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/server/core.c?rev=295141&r1=295140&r2=295141&view=diff
==============================================================================
--- httpd/httpd/trunk/server/core.c (original)
+++ httpd/httpd/trunk/server/core.c Wed Oct 5 16:37:53 2005
@@ -3767,11 +3767,6 @@
ap_set_module_config(r->request_config, &core_module, req_cfg);
- /* Begin by presuming any module can make its own path_info assumptions,
- * until some module interjects and changes the value.
- */
- r->used_path_info = AP_REQ_DEFAULT_PATH_INFO;
-
return OK;
}
Modified: httpd/httpd/trunk/server/protocol.c
URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/server/protocol.c?rev=295141&r1=295140&r2=295141&view=diff
==============================================================================
--- httpd/httpd/trunk/server/protocol.c (original)
+++ httpd/httpd/trunk/server/protocol.c Wed Oct 5 16:37:53 2005
@@ -869,6 +869,11 @@
r->status = HTTP_REQUEST_TIME_OUT; /* Until we get a request */
r->the_request = NULL;
+ /* Begin by presuming any module can make its own path_info assumptions,
+ * until some module interjects and changes the value.
+ */
+ r->used_path_info = AP_REQ_DEFAULT_PATH_INFO;
+
tmp_bb = apr_brigade_create(r->pool, r->connection->bucket_alloc);
/* Get the request... */
Modified: httpd/httpd/trunk/server/request.c
URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/server/request.c?rev=295141&r1=295140&r2=295141&view=diff
==============================================================================
--- httpd/httpd/trunk/server/request.c (original)
+++ httpd/httpd/trunk/server/request.c Wed Oct 5 16:37:53 2005
@@ -1531,6 +1531,11 @@
*/
ap_run_create_request(rnew);
+ /* Begin by presuming any module can make its own path_info assumptions,
+ * until some module interjects and changes the value.
+ */
+ rnew->used_path_info = AP_REQ_DEFAULT_PATH_INFO;
+
return rnew;
}