[GitHub] [spark] navinvishy commented on a diff in pull request #38947: SPARK-41231: Adds an array_prepend function to catalyst

[GitBox <gi...@apache.org>]

navinvishy commented on code in PR #38947:
URL: https://github.com/apache/spark/pull/38947#discussion_r1041587895


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -1376,35 +1418,148 @@ case class ArrayContains(left: Expression, right: Expression)
            |   break;
            |}
          """.stripMargin
-      } else {
-        s"""
+        } else {
+          s"""
            |if (${ctx.genEqual(right.dataType, value, getValue)}) {
            |  ${ev.value} = true;
            |  break;
            |}
          """.stripMargin
-      }
-      s"""
+        }
+        s"""
          |for (int $i = 0; $i < $arr.numElements(); $i ++) {
          |  $loopBodyCode
          |}
        """.stripMargin
-    })
+      })
   }
 
   override def prettyName: String = "array_contains"
 
   override protected def withNewChildrenInternal(
-      newLeft: Expression, newRight: Expression): ArrayContains =
+      newLeft: Expression,
+      newRight: Expression): ArrayContains =
     copy(left = newLeft, right = newRight)
 }
+@ExpressionDescription(

Review Comment:
   Relevant diff here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org