You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/12/22 13:47:38 UTC

[GitHub] [carbondata] ShreelekhyaG opened a new pull request #4064: [CARBONDATA-4096] SDK read fails from cluster and sdk read filter query on sort column giving wrong result with IndexServer

ShreelekhyaG opened a new pull request #4064:
URL: https://github.com/apache/carbondata/pull/4064


    ### Why is this PR needed?
    1) Create a table and read from sdk written files fails in cluster with `java.nio.file.NoSuchFileException: hdfs:/hacluster/user/hive/warehouse/carbon.store/default/sdk`.
   2) After fixing the above path issue, filter query on sort column gives the wrong result with IndexServer.
    
    ### What changes were proposed in this PR?
   1) In `getAllDeleteDeltaFiles` , used CarbonFiles.listFiles instead of Files.walk to handle custom file types.
   2) In PruneWithFilter ,  `isResolvedOnSegment`  is used in filterResolver step. Have set table and expression on executor side, so indexserver can use this in filterResolver step.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No, verified in the cluster.
   
       
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [carbondata] kunal642 commented on pull request #4064: [CARBONDATA-4096] SDK read fails from cluster and sdk read filter query on sort column giving wrong result with IndexServer

Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4064:
URL: https://github.com/apache/carbondata/pull/4064#issuecomment-764530852


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4064: [CARBONDATA-4096] SDK read fails from cluster and sdk read filter query on sort column giving wrong result with IndexServer

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4064:
URL: https://github.com/apache/carbondata/pull/4064#issuecomment-749591901


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5231/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4064: [CARBONDATA-4096] SDK read fails from cluster and sdk read filter query on sort column giving wrong result with IndexServer

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4064:
URL: https://github.com/apache/carbondata/pull/4064#issuecomment-763458823


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3559/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4064: [CARBONDATA-4096] SDK read fails from cluster and sdk read filter query on sort column giving wrong result with IndexServer

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4064:
URL: https://github.com/apache/carbondata/pull/4064#issuecomment-763452360


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5319/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [carbondata] kunal642 commented on pull request #4064: [CARBONDATA-4096] SDK read fails from cluster and sdk read filter query on sort column giving wrong result with IndexServer

Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4064:
URL: https://github.com/apache/carbondata/pull/4064#issuecomment-764530852


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4064: [CARBONDATA-4096] SDK read fails from cluster and sdk read filter query on sort column giving wrong result with IndexServer

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4064:
URL: https://github.com/apache/carbondata/pull/4064#issuecomment-749599127


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3470/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [carbondata] kunal642 commented on pull request #4064: [CARBONDATA-4096] SDK read fails from cluster and sdk read filter query on sort column giving wrong result with IndexServer

Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4064:
URL: https://github.com/apache/carbondata/pull/4064#issuecomment-763398749


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [carbondata] asfgit closed pull request #4064: [CARBONDATA-4096] SDK read fails from cluster and sdk read filter query on sort column giving wrong result with IndexServer

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4064:
URL: https://github.com/apache/carbondata/pull/4064


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org