[GitHub] [pinot] snleee commented on issue #8585: Support balanced segment assignment for consuming segments

[GitBox <gi...@apache.org>]

snleee commented on issue #8585:
URL: https://github.com/apache/pinot/issues/8585#issuecomment-1109402199

   Currently, we have `SegmentAssignment` interface and `OfflineSegmentAssignment & RealtimeSegmentAssignment` as its implementation. This approach doesn't allow us to pick the custom segment assignment strategy. 
   
   I think that we should first add the interface for `SegmentAssignmentStrategy` and make `SegmentAssignment` to use `SegmentAssignmentStrategy.assignSegment()`.
   
   
   ```
   /**
    * Interface for segment assignment and table rebalance.
    * <p>
    * TODO: Add SegmentAssignmentStrategy interface and support custom segment assignment strategy (e.g. cost based segment
    *       assignment). SegmentAssignmentStrategy should not be coupled with SegmentAssignment, and SegmentAssignment
    *       should be able to choose the segment assignment strategy based on the configuration.
    */
   public interface SegmentAssignment {
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org