You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2022/02/17 21:36:15 UTC
[kudu-CR] [util] harmonize random util
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18248
Change subject: [util] harmonize random_util
......................................................................
[util] harmonize random_util
Functions defined in int128_util.h caused ambiguous overload errors
for:
std::ostream& operator<<(std::ostream& os, const unsigned __int128& val),
This patch includes "kudu/util/int128.h" instead of
"kudu/util/int128_util.h".
Change-Id: I247d68bedbd021aa59b8f057e0eed3166c08ac33
---
M src/kudu/util/random_util-test.cc
M src/kudu/util/random_util.h
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/18248/1
--
To view, visit http://gerrit.cloudera.org:8080/18248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I247d68bedbd021aa59b8f057e0eed3166c08ac33
Gerrit-Change-Number: 18248
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] [util] harmonize random util
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18248 )
Change subject: [util] harmonize random_util
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I247d68bedbd021aa59b8f057e0eed3166c08ac33
Gerrit-Change-Number: 18248
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Feb 2022 01:48:02 +0000
Gerrit-HasComments: No
[kudu-CR] [util] harmonize random util
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18248 )
Change subject: [util] harmonize random_util
......................................................................
Patch Set 1: Verified+1
For some reason, IWYU wants "kudu/util/int128.h" to be included along with "kudu/util/int128_util.h" in random_util-test.cc.
--
To view, visit http://gerrit.cloudera.org:8080/18248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I247d68bedbd021aa59b8f057e0eed3166c08ac33
Gerrit-Change-Number: 18248
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Feb 2022 22:44:04 +0000
Gerrit-HasComments: No
[kudu-CR] [util] harmonize random util
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [util] harmonize random_util
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I247d68bedbd021aa59b8f057e0eed3166c08ac33
Gerrit-Change-Number: 18248
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [util] harmonize random util
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18248 )
Change subject: [util] harmonize random_util
......................................................................
Patch Set 2:
> Patch Set 1: Verified+1
>
> For some reason, IWYU wants "kudu/util/int128.h" to be included along with "kudu/util/int128_util.h" in random_util-test.cc.
Done. Thanks for the fast reviews!
--
To view, visit http://gerrit.cloudera.org:8080/18248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I247d68bedbd021aa59b8f057e0eed3166c08ac33
Gerrit-Change-Number: 18248
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Feb 2022 01:03:49 +0000
Gerrit-HasComments: No
[kudu-CR] [util] harmonize random util
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18248
to look at the new patch set (#2).
Change subject: [util] harmonize random_util
......................................................................
[util] harmonize random_util
Functions defined in int128_util.h caused ambiguous overload errors
for:
std::ostream& operator<<(std::ostream& os, const unsigned __int128& val),
This patch includes "kudu/util/int128.h" instead of
"kudu/util/int128_util.h".
Change-Id: I247d68bedbd021aa59b8f057e0eed3166c08ac33
---
M src/kudu/util/random_util-test.cc
M src/kudu/util/random_util.h
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/18248/2
--
To view, visit http://gerrit.cloudera.org:8080/18248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I247d68bedbd021aa59b8f057e0eed3166c08ac33
Gerrit-Change-Number: 18248
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [util] harmonize random util
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18248 )
Change subject: [util] harmonize random_util
......................................................................
[util] harmonize random_util
Functions defined in int128_util.h caused ambiguous overload errors
for:
std::ostream& operator<<(std::ostream& os, const unsigned __int128& val),
This patch includes "kudu/util/int128.h" instead of
"kudu/util/int128_util.h".
Change-Id: I247d68bedbd021aa59b8f057e0eed3166c08ac33
Reviewed-on: http://gerrit.cloudera.org:8080/18248
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/util/random_util-test.cc
M src/kudu/util/random_util.h
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I247d68bedbd021aa59b8f057e0eed3166c08ac33
Gerrit-Change-Number: 18248
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [util] harmonize random util
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18248 )
Change subject: [util] harmonize random_util
......................................................................
Patch Set 2: Verified+1
Unrelated test failure.
--
To view, visit http://gerrit.cloudera.org:8080/18248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I247d68bedbd021aa59b8f057e0eed3166c08ac33
Gerrit-Change-Number: 18248
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Feb 2022 01:47:43 +0000
Gerrit-HasComments: No