[jira] [Updated] (TEZ-2857) Flakey tests in TestDAGImpl

["Siddharth Seth (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TEZ-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Siddharth Seth updated TEZ-2857:
--------------------------------
    Attachment: TEZ-2857.1.txt

Modified the tests to make them deterministic, rather than having races.

[~hitesh] - please review.

> Flakey tests in TestDAGImpl
> ---------------------------
>
>                 Key: TEZ-2857
>                 URL: https://issues.apache.org/jira/browse/TEZ-2857
>             Project: Apache Tez
>          Issue Type: Task
>    Affects Versions: 0.4.0
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: TEZ-2857.1.txt
>
>
> testDAGKill
> {code}
> java.lang.AssertionError: expected:<6> but was:<5>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotEquals(Assert.java:743)
> 	at org.junit.Assert.assertEquals(Assert.java:118)
> 	at org.junit.Assert.assertEquals(Assert.java:555)
> 	at org.junit.Assert.assertEquals(Assert.java:542)
> 	at org.apache.tez.dag.app.dag.impl.TestDAGImpl.testDAGKill(TestDAGImpl.java:1880)
> {code}
> testDAGKillPending
> {code}
> java.lang.AssertionError: expected:<5> but was:<3>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotEquals(Assert.java:743)
> 	at org.junit.Assert.assertEquals(Assert.java:118)
> 	at org.junit.Assert.assertEquals(Assert.java:555)
> 	at org.junit.Assert.assertEquals(Assert.java:542)
> 	at org.apache.tez.dag.app.dag.impl.TestDAGImpl.testDAGKillPending(TestDAGImpl.java:1916)
> {code}
> There's a race between vertex success and vertex terminate reaching the vertices, which cause the tests to be flakey.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)