You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/09 15:38:52 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #753: chore: rename the dockerfile that may be confusing
nic-chen opened a new pull request #753:
URL: https://github.com/apache/apisix-dashboard/pull/753
I try to move the Dockerfile into `api/test/docker`, but it run fail:
```
COPY failed: Forbidden path outside the build context
```
I think renaming is better than nothing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis merged pull request #753: chore: move the Dockerfile that may be confusing
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #753:
URL: https://github.com/apache/apisix-dashboard/pull/753
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #753: chore: rename the dockerfile that may be confusing
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #753:
URL: https://github.com/apache/apisix-dashboard/pull/753#issuecomment-724103542
> This is a temporary solution, we will put it completely in `api/test/docker` later, right?
>
> Please confirm.
updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #753: chore: rename the dockerfile that may be confusing
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #753:
URL: https://github.com/apache/apisix-dashboard/pull/753#issuecomment-724097210
This is a temporary solution, we will put it completely in `api/test/docker` later, right?
Please confirm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #753: chore: rename the dockerfile that may be confusing
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #753:
URL: https://github.com/apache/apisix-dashboard/pull/753#issuecomment-724092826
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/753?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@a050e84`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/753?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #753 +/- ##
=========================================
Coverage ? 42.83%
=========================================
Files ? 18
Lines ? 1249
Branches ? 0
=========================================
Hits ? 535
Misses ? 625
Partials ? 89
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/753?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/753?src=pr&el=footer). Last update [a050e84...6d04c5c](https://codecov.io/gh/apache/apisix-dashboard/pull/753?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org