You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2014/05/19 13:59:54 UTC
Review Request 21629: CLOUDSTACK-4757. Support OVA files containing multiple
disks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21629/
-----------------------------------------------------------
Review request for cloudstack.
Bugs: CLOUDSTACK-4757
https://issues.apache.org/jira/browse/CLOUDSTACK-4757
Repository: cloudstack-git
Description
-------
This patch is for 4.5 feature 'Support OVA files containing multiple disks'.
Functional spec for the feature is available at - https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+OVA+files+containing+multiple+disks
Diffs
-----
api/src/com/cloud/agent/api/to/DatadiskTO.java PRE-CREATION
api/src/com/cloud/storage/Storage.java cc8d010
api/src/com/cloud/template/VirtualMachineTemplate.java 599212b
api/src/com/cloud/vm/DiskProfile.java a37f7aa
api/src/com/cloud/vm/UserVmService.java af4e1d3
api/src/org/apache/cloudstack/api/ApiConstants.java a3faca7
api/src/org/apache/cloudstack/api/ResponseGenerator.java 10fb6df
api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 7a2a158
api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 0adc57b
api/src/org/apache/cloudstack/api/response/TemplateResponse.java 3e21043
core/src/com/cloud/agent/api/storage/CreateDatadiskTemplateAnswer.java PRE-CREATION
core/src/com/cloud/agent/api/storage/CreateDatadiskTemplateCommand.java PRE-CREATION
core/src/com/cloud/agent/api/storage/GetDatadisksAnswer.java PRE-CREATION
core/src/com/cloud/agent/api/storage/GetDatadisksCommand.java PRE-CREATION
core/src/com/cloud/storage/template/OVAProcessor.java 0db3bb0
core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java b201c38
engine/api/src/com/cloud/vm/VirtualMachineManager.java f070210
engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java df0b5e8
engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 93f969f
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/EndPointSelector.java 4657316
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/TemplateService.java 88ce932
engine/api/src/org/apache/cloudstack/storage/image/datastore/ImageStoreEntity.java 43a0f75
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java e15d287
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2b49954
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 6256e25
engine/schema/src/com/cloud/storage/VMTemplateVO.java 9a77cbf
engine/schema/src/com/cloud/storage/dao/VMTemplateDao.java 2b815d8
engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 401a4a2
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java 4e6ab6b
engine/storage/image/src/org/apache/cloudstack/storage/image/store/ImageStoreImpl.java 8da7eb7
engine/storage/image/src/org/apache/cloudstack/storage/image/store/TemplateObject.java 7288d45
engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java 304f959
engine/storage/src/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java 7ed11ec
engine/storage/src/org/apache/cloudstack/storage/image/ImageStoreDriver.java fa7ea37
engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java c1aa8c2
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManager.java f78f370
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java c1b907e
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 0024b44
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSecondaryStorageResourceHandler.java f633774
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java ff893b2
plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 89e4ab5
server/src/com/cloud/api/ApiResponseHelper.java 250f5a9
server/src/com/cloud/api/query/QueryManagerImpl.java 8e020fc
server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java 80ef0f6
server/src/com/cloud/api/query/vo/TemplateJoinVO.java 834a9ce
server/src/com/cloud/network/as/AutoScaleManagerImpl.java 09c6694
server/src/com/cloud/template/HypervisorTemplateAdapter.java 51dedf7
server/src/com/cloud/template/TemplateManagerImpl.java ead841f
server/src/com/cloud/vm/UserVmManagerImpl.java 3d262b7
setup/db/db/schema-440to450.sql 4cc4879
test/integration/component/test_ova_templates_with_multiple_disks.py PRE-CREATION
tools/marvin/marvin/lib/base.py 966e8dc
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 38b68b3
Diff: https://reviews.apache.org/r/21629/diff/
Testing
-------
- Marvin test for this feature is available in patch
Thanks,
Likitha Shetty
Re: Review Request 21629: CLOUDSTACK-4757. Support OVA files containing
multiple disks.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21629/#review43630
-----------------------------------------------------------
Commit 87d87a6f30c45125e5769f04e8d4260074c79f87 in cloudstack's branch refs/heads/multiple-disk-ova from Likitha Shetty
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=87d87a6 ]
CLOUDSTACK-4757. Improvements to the marvin test.
- ASF Subversion and Git Services
On May 19, 2014, 11:59 a.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21629/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 11:59 a.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-4757
> https://issues.apache.org/jira/browse/CLOUDSTACK-4757
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch is for 4.5 feature 'Support OVA files containing multiple disks'.
> Functional spec for the feature is available at - https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+OVA+files+containing+multiple+disks
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/DatadiskTO.java PRE-CREATION
> api/src/com/cloud/storage/Storage.java cc8d010
> api/src/com/cloud/template/VirtualMachineTemplate.java 599212b
> api/src/com/cloud/vm/DiskProfile.java a37f7aa
> api/src/com/cloud/vm/UserVmService.java af4e1d3
> api/src/org/apache/cloudstack/api/ApiConstants.java a3faca7
> api/src/org/apache/cloudstack/api/ResponseGenerator.java 10fb6df
> api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 7a2a158
> api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 0adc57b
> api/src/org/apache/cloudstack/api/response/TemplateResponse.java 3e21043
> core/src/com/cloud/agent/api/storage/CreateDatadiskTemplateAnswer.java PRE-CREATION
> core/src/com/cloud/agent/api/storage/CreateDatadiskTemplateCommand.java PRE-CREATION
> core/src/com/cloud/agent/api/storage/GetDatadisksAnswer.java PRE-CREATION
> core/src/com/cloud/agent/api/storage/GetDatadisksCommand.java PRE-CREATION
> core/src/com/cloud/storage/template/OVAProcessor.java 0db3bb0
> core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java b201c38
> engine/api/src/com/cloud/vm/VirtualMachineManager.java f070210
> engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java df0b5e8
> engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 93f969f
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/EndPointSelector.java 4657316
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/TemplateService.java 88ce932
> engine/api/src/org/apache/cloudstack/storage/image/datastore/ImageStoreEntity.java 43a0f75
> engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java e15d287
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2b49954
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 6256e25
> engine/schema/src/com/cloud/storage/VMTemplateVO.java 9a77cbf
> engine/schema/src/com/cloud/storage/dao/VMTemplateDao.java 2b815d8
> engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 401a4a2
> engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java 4e6ab6b
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/ImageStoreImpl.java 8da7eb7
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/TemplateObject.java 7288d45
> engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java 304f959
> engine/storage/src/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java 7ed11ec
> engine/storage/src/org/apache/cloudstack/storage/image/ImageStoreDriver.java fa7ea37
> engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java c1aa8c2
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManager.java f78f370
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java c1b907e
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 0024b44
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSecondaryStorageResourceHandler.java f633774
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java ff893b2
> plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 89e4ab5
> server/src/com/cloud/api/ApiResponseHelper.java 250f5a9
> server/src/com/cloud/api/query/QueryManagerImpl.java 8e020fc
> server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java 80ef0f6
> server/src/com/cloud/api/query/vo/TemplateJoinVO.java 834a9ce
> server/src/com/cloud/network/as/AutoScaleManagerImpl.java 09c6694
> server/src/com/cloud/template/HypervisorTemplateAdapter.java 51dedf7
> server/src/com/cloud/template/TemplateManagerImpl.java ead841f
> server/src/com/cloud/vm/UserVmManagerImpl.java 3d262b7
> setup/db/db/schema-440to450.sql 4cc4879
> test/integration/component/test_ova_templates_with_multiple_disks.py PRE-CREATION
> tools/marvin/marvin/lib/base.py 966e8dc
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 38b68b3
>
> Diff: https://reviews.apache.org/r/21629/diff/
>
>
> Testing
> -------
>
> - Marvin test for this feature is available in patch
>
>
> Thanks,
>
> Likitha Shetty
>
>
Re: Review Request 21629: CLOUDSTACK-4757. Support OVA files containing
multiple disks.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21629/#review43704
-----------------------------------------------------------
Commit ebc92d6cd758d031f9d05ab7b277d5541149f771 in cloudstack's branch refs/heads/multiple-disk-ova from Likitha Shetty
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ebc92d6 ]
CLOUDSTACK-4757. Update API params
- ASF Subversion and Git Services
On May 21, 2014, 4:10 p.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21629/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 4:10 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-4757
> https://issues.apache.org/jira/browse/CLOUDSTACK-4757
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch is for 4.5 feature 'Support OVA files containing multiple disks'.
> Functional spec for the feature is available at - https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+OVA+files+containing+multiple+disks
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/DatadiskTO.java PRE-CREATION
> api/src/com/cloud/storage/Storage.java cc8d010
> api/src/com/cloud/template/VirtualMachineTemplate.java 599212b
> api/src/com/cloud/vm/DiskProfile.java a37f7aa
> api/src/com/cloud/vm/UserVmService.java af4e1d3
> api/src/org/apache/cloudstack/api/ApiConstants.java a3faca7
> api/src/org/apache/cloudstack/api/ResponseGenerator.java 10fb6df
> api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 7a2a158
> api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 0adc57b
> api/src/org/apache/cloudstack/api/response/TemplateResponse.java 3e21043
> core/src/com/cloud/agent/api/storage/CreateDatadiskTemplateAnswer.java PRE-CREATION
> core/src/com/cloud/agent/api/storage/CreateDatadiskTemplateCommand.java PRE-CREATION
> core/src/com/cloud/agent/api/storage/GetDatadisksAnswer.java PRE-CREATION
> core/src/com/cloud/agent/api/storage/GetDatadisksCommand.java PRE-CREATION
> core/src/com/cloud/storage/template/OVAProcessor.java 0db3bb0
> core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java b201c38
> engine/api/src/com/cloud/vm/VirtualMachineManager.java f070210
> engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java df0b5e8
> engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 93f969f
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/EndPointSelector.java 4657316
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/TemplateService.java 88ce932
> engine/api/src/org/apache/cloudstack/storage/image/datastore/ImageStoreEntity.java 43a0f75
> engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java e15d287
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2b49954
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 6256e25
> engine/schema/src/com/cloud/storage/VMTemplateVO.java 9a77cbf
> engine/schema/src/com/cloud/storage/dao/VMTemplateDao.java 2b815d8
> engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 401a4a2
> engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java 4e6ab6b
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/ImageStoreImpl.java 8da7eb7
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/TemplateObject.java 7288d45
> engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java 304f959
> engine/storage/src/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java 7ed11ec
> engine/storage/src/org/apache/cloudstack/storage/image/ImageStoreDriver.java fa7ea37
> engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java c1aa8c2
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManager.java f78f370
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java c1b907e
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 0024b44
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSecondaryStorageResourceHandler.java f633774
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java ff893b2
> plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 89e4ab5
> server/src/com/cloud/api/ApiResponseHelper.java 250f5a9
> server/src/com/cloud/api/query/QueryManagerImpl.java 8e020fc
> server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java 80ef0f6
> server/src/com/cloud/api/query/vo/TemplateJoinVO.java 834a9ce
> server/src/com/cloud/network/as/AutoScaleManagerImpl.java 09c6694
> server/src/com/cloud/template/HypervisorTemplateAdapter.java 51dedf7
> server/src/com/cloud/template/TemplateManagerImpl.java ead841f
> server/src/com/cloud/vm/UserVmManagerImpl.java 3d262b7
> setup/db/db/schema-440to450.sql 4cc4879
> test/integration/component/test_ova_templates_with_multiple_disks.py PRE-CREATION
> tools/marvin/marvin/lib/base.py 966e8dc
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 38b68b3
>
> Diff: https://reviews.apache.org/r/21629/diff/
>
>
> Testing
> -------
>
> - Marvin test for this feature is available in patch
>
>
> Thanks,
>
> Likitha Shetty
>
>
Re: Review Request 21629: CLOUDSTACK-4757. Support OVA files containing
multiple disks.
Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21629/
-----------------------------------------------------------
(Updated May 21, 2014, 4:10 p.m.)
Review request for cloudstack.
Bugs: CLOUDSTACK-4757
https://issues.apache.org/jira/browse/CLOUDSTACK-4757
Repository: cloudstack-git
Description
-------
This patch is for 4.5 feature 'Support OVA files containing multiple disks'.
Functional spec for the feature is available at - https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+OVA+files+containing+multiple+disks
Diffs (updated)
-----
api/src/com/cloud/agent/api/to/DatadiskTO.java PRE-CREATION
api/src/com/cloud/storage/Storage.java cc8d010
api/src/com/cloud/template/VirtualMachineTemplate.java 599212b
api/src/com/cloud/vm/DiskProfile.java a37f7aa
api/src/com/cloud/vm/UserVmService.java af4e1d3
api/src/org/apache/cloudstack/api/ApiConstants.java a3faca7
api/src/org/apache/cloudstack/api/ResponseGenerator.java 10fb6df
api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 7a2a158
api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 0adc57b
api/src/org/apache/cloudstack/api/response/TemplateResponse.java 3e21043
core/src/com/cloud/agent/api/storage/CreateDatadiskTemplateAnswer.java PRE-CREATION
core/src/com/cloud/agent/api/storage/CreateDatadiskTemplateCommand.java PRE-CREATION
core/src/com/cloud/agent/api/storage/GetDatadisksAnswer.java PRE-CREATION
core/src/com/cloud/agent/api/storage/GetDatadisksCommand.java PRE-CREATION
core/src/com/cloud/storage/template/OVAProcessor.java 0db3bb0
core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java b201c38
engine/api/src/com/cloud/vm/VirtualMachineManager.java f070210
engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java df0b5e8
engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 93f969f
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/EndPointSelector.java 4657316
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/TemplateService.java 88ce932
engine/api/src/org/apache/cloudstack/storage/image/datastore/ImageStoreEntity.java 43a0f75
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java e15d287
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2b49954
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 6256e25
engine/schema/src/com/cloud/storage/VMTemplateVO.java 9a77cbf
engine/schema/src/com/cloud/storage/dao/VMTemplateDao.java 2b815d8
engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 401a4a2
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java 4e6ab6b
engine/storage/image/src/org/apache/cloudstack/storage/image/store/ImageStoreImpl.java 8da7eb7
engine/storage/image/src/org/apache/cloudstack/storage/image/store/TemplateObject.java 7288d45
engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java 304f959
engine/storage/src/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java 7ed11ec
engine/storage/src/org/apache/cloudstack/storage/image/ImageStoreDriver.java fa7ea37
engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java c1aa8c2
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManager.java f78f370
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java c1b907e
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 0024b44
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSecondaryStorageResourceHandler.java f633774
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java ff893b2
plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 89e4ab5
server/src/com/cloud/api/ApiResponseHelper.java 250f5a9
server/src/com/cloud/api/query/QueryManagerImpl.java 8e020fc
server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java 80ef0f6
server/src/com/cloud/api/query/vo/TemplateJoinVO.java 834a9ce
server/src/com/cloud/network/as/AutoScaleManagerImpl.java 09c6694
server/src/com/cloud/template/HypervisorTemplateAdapter.java 51dedf7
server/src/com/cloud/template/TemplateManagerImpl.java ead841f
server/src/com/cloud/vm/UserVmManagerImpl.java 3d262b7
setup/db/db/schema-440to450.sql 4cc4879
test/integration/component/test_ova_templates_with_multiple_disks.py PRE-CREATION
tools/marvin/marvin/lib/base.py 966e8dc
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 38b68b3
Diff: https://reviews.apache.org/r/21629/diff/
Testing
-------
- Marvin test for this feature is available in patch
Thanks,
Likitha Shetty
Re: Review Request 21629: CLOUDSTACK-4757. Support OVA files containing
multiple disks.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21629/#review43629
-----------------------------------------------------------
Commit 30b8eba92342d391abef9bb3efa1c6efcf588875 in cloudstack's branch refs/heads/multiple-disk-ova from Likitha Shetty
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=30b8eba ]
CLOUDSTACK-4757. Cleanup datadisk templates that have already been created in case creation of one of the datadisk template fails
- ASF Subversion and Git Services
On May 19, 2014, 11:59 a.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21629/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 11:59 a.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-4757
> https://issues.apache.org/jira/browse/CLOUDSTACK-4757
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch is for 4.5 feature 'Support OVA files containing multiple disks'.
> Functional spec for the feature is available at - https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+OVA+files+containing+multiple+disks
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/DatadiskTO.java PRE-CREATION
> api/src/com/cloud/storage/Storage.java cc8d010
> api/src/com/cloud/template/VirtualMachineTemplate.java 599212b
> api/src/com/cloud/vm/DiskProfile.java a37f7aa
> api/src/com/cloud/vm/UserVmService.java af4e1d3
> api/src/org/apache/cloudstack/api/ApiConstants.java a3faca7
> api/src/org/apache/cloudstack/api/ResponseGenerator.java 10fb6df
> api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 7a2a158
> api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 0adc57b
> api/src/org/apache/cloudstack/api/response/TemplateResponse.java 3e21043
> core/src/com/cloud/agent/api/storage/CreateDatadiskTemplateAnswer.java PRE-CREATION
> core/src/com/cloud/agent/api/storage/CreateDatadiskTemplateCommand.java PRE-CREATION
> core/src/com/cloud/agent/api/storage/GetDatadisksAnswer.java PRE-CREATION
> core/src/com/cloud/agent/api/storage/GetDatadisksCommand.java PRE-CREATION
> core/src/com/cloud/storage/template/OVAProcessor.java 0db3bb0
> core/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java b201c38
> engine/api/src/com/cloud/vm/VirtualMachineManager.java f070210
> engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java df0b5e8
> engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 93f969f
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/EndPointSelector.java 4657316
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/TemplateService.java 88ce932
> engine/api/src/org/apache/cloudstack/storage/image/datastore/ImageStoreEntity.java 43a0f75
> engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java e15d287
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2b49954
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 6256e25
> engine/schema/src/com/cloud/storage/VMTemplateVO.java 9a77cbf
> engine/schema/src/com/cloud/storage/dao/VMTemplateDao.java 2b815d8
> engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 401a4a2
> engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java 4e6ab6b
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/ImageStoreImpl.java 8da7eb7
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/TemplateObject.java 7288d45
> engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java 304f959
> engine/storage/src/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java 7ed11ec
> engine/storage/src/org/apache/cloudstack/storage/image/ImageStoreDriver.java fa7ea37
> engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java c1aa8c2
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManager.java f78f370
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java c1b907e
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 0024b44
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSecondaryStorageResourceHandler.java f633774
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java ff893b2
> plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 89e4ab5
> server/src/com/cloud/api/ApiResponseHelper.java 250f5a9
> server/src/com/cloud/api/query/QueryManagerImpl.java 8e020fc
> server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java 80ef0f6
> server/src/com/cloud/api/query/vo/TemplateJoinVO.java 834a9ce
> server/src/com/cloud/network/as/AutoScaleManagerImpl.java 09c6694
> server/src/com/cloud/template/HypervisorTemplateAdapter.java 51dedf7
> server/src/com/cloud/template/TemplateManagerImpl.java ead841f
> server/src/com/cloud/vm/UserVmManagerImpl.java 3d262b7
> setup/db/db/schema-440to450.sql 4cc4879
> test/integration/component/test_ova_templates_with_multiple_disks.py PRE-CREATION
> tools/marvin/marvin/lib/base.py 966e8dc
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 38b68b3
>
> Diff: https://reviews.apache.org/r/21629/diff/
>
>
> Testing
> -------
>
> - Marvin test for this feature is available in patch
>
>
> Thanks,
>
> Likitha Shetty
>
>