You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org> on 2011/11/18 15:10:53 UTC

[jira] [Commented] (BOOKKEEPER-114) add a shutdown hook to shut down bookie server safely.

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152884#comment-13152884 ] 

Ivan Kelly commented on BOOKKEEPER-114:
---------------------------------------

While this change is good, a non-clean shutdown shouldn't corrupt data unrecoverably. If it does, then there's a pretty serious bug. This is the reason that we have a journal, so we should be able to handle it.
                
> add a shutdown hook to shut down bookie server safely.
> ------------------------------------------------------
>
>                 Key: BOOKKEEPER-114
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-114
>             Project: Bookkeeper
>          Issue Type: Improvement
>    Affects Versions: 4.0.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.0.0
>
>         Attachments: BOOKKEEPER-114.patch
>
>
> Currently, if Bookie server is terminated, e.g. CTRL-C, kill -SIGTERM pid, kill pid, the data buffered in BufferedChannel has no chanced to be flushed, which may make files corrupted. 
> We should add a shutdown hook to shut down bookie server safely, which will be called when JVM is terminated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira