You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Leif Hedstrom (JIRA)" <ji...@apache.org> on 2016/09/15 15:30:20 UTC
[jira] [Commented] (TS-4871) CID 1362796: Integer handling issues
(NEGATIVE_RETURNS) in statistics plugin
[ https://issues.apache.org/jira/browse/TS-4871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493668#comment-15493668 ]
Leif Hedstrom commented on TS-4871:
-----------------------------------
Albeit benign, we should fix this.
> CID 1362796: Integer handling issues (NEGATIVE_RETURNS) in statistics plugin
> ------------------------------------------------------------------------------
>
> Key: TS-4871
> URL: https://issues.apache.org/jira/browse/TS-4871
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: Leif Hedstrom
> Assignee: James Peach
> Labels: coverity
> Fix For: 7.0.0
>
>
> {code}
> *** CID 1362796: Integer handling issues (NEGATIVE_RETURNS)
> /example/statistic/statistic.cc: 50 in TSPluginInit()
> 44
> 45 int id;
> 46 const char name[] = "example.statistic.now";
> 47
> 48 if (TSStatFindName(name, &id) == TS_ERROR) {
> 49 id = TSStatCreate(name, TS_RECORDDATATYPE_INT, TS_STAT_NON_PERSISTENT, TS_STAT_SYNC_SUM);
> CID 1362796: Integer handling issues (NEGATIVE_RETURNS)
> Variable "id" tests negative.
> 50 if (id == TS_ERROR) {
> 51 TSError("%s: failed to register '%s'", PLUGIN_NAME, name);
> 52 }
> 53 }
> 54
> 55 TSError("%s: %s registered with id %d", PLUGIN_NAME, name, id);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)