You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by sijie <gi...@git.apache.org> on 2017/06/01 11:08:51 UTC
[GitHub] bookkeeper pull request #174: BOOKKEEPER-748: Move fence requests out of rea...
GitHub user sijie opened a pull request:
https://github.com/apache/bookkeeper/pull/174
BOOKKEEPER-748: Move fence requests out of read threads
This change is moving the fence request out of current read threads and using callback to trigger scheduling read entry and also it refactors the ReadEntryProcessV3 to support long poll in the subsequent requests.
Major changes:
- change fence request to use SettableFuture
- refactor ReadEntryProcessV3: to support run fence request in callback and support long poll (in subsequent requests)
- fix stats issue: requests stats measure the latency from bookie receives the request until it sends the response.
- remove "public static final" for state fields. it is not needed for variables in Interface.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sijie/bookkeeper longpoll/part1_server_side_change
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #174
----
commit 56f6824a6f57360fbd999995d9959a2966046183
Author: Robin Dhamankar <rd...@twitter.com>
Date: 2014-02-12T22:50:47Z
BookKeeper: Stats for pending tasks on server thread pools
- Stats for pending tasks on server thread pools
RB_ID=286873
commit 8364c12d705b1eabae394807419a9989a9608f56
Author: Sijie Guo <si...@apache.org>
Date: 2017-06-01T07:37:24Z
Improvements on OrderedSafeExecutor
- use listeningscheduledexecutorservice for the threads
- as a general util class, expose chooseThread to allow applications use specific thread
- add a method to force shutdown executor
commit ac8431c4721498f5fd7c6d387a09039652c47f9f
Author: Sijie Guo <si...@apache.org>
Date: 2017-06-01T09:50:18Z
Long Poll (Part 2) - Run fence request in a separated thread
commit d43400d3e42057b938dc6b31b1761004da1f963b
Author: Sijie Guo <si...@apache.org>
Date: 2017-06-01T09:51:35Z
Merge branch 'master' into add_monitored_thread_pool
commit c1a02b3d371c93eaf4d8ff14ee3e4f669ab09874
Author: Sijie Guo <si...@apache.org>
Date: 2017-06-01T09:51:58Z
Merge branch 'add_monitored_thread_pool' into longpoll/part1_server_side_change
commit c57fefdae1de8eec6e44a2af692fb6fe07224abd
Author: Sijie Guo <si...@apache.org>
Date: 2017-06-01T10:34:22Z
BOOKKEEPER-748: Move fence requests out of read threads
commit d431c643c7feb78045d9478988fe8fbacc7ed703
Author: Sijie Guo <si...@apache.org>
Date: 2017-06-01T11:01:38Z
Merge the change for fence request
commit 4e14991a28cd30bca0e42803c49eafc39b11fc60
Author: Sijie Guo <si...@apache.org>
Date: 2017-06-01T11:02:17Z
Merge remote-tracking branch 'apache/master' into longpoll/part1_server_side_change
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #174: BOOKKEEPER-748: Move fence requests out of read threa...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/174
The long poll part is mainly contributed by Robin & Leigh. Please list them when merging long poll related changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #174: BOOKKEEPER-748: Move fence requests out of read threa...
Posted by jiazhai <gi...@git.apache.org>.
Github user jiazhai commented on the issue:
https://github.com/apache/bookkeeper/pull/174
This is a great feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #174: BOOKKEEPER-748: Move fence requests out of read threa...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/174
rebased to latest master and wait CI to complete.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #174: BOOKKEEPER-748: Move fence requests out of read threa...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/174
I did a review on code. It looks great.
All tests are passing.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper pull request #174: BOOKKEEPER-748: Move fence requests out of rea...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bookkeeper/pull/174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #174: BOOKKEEPER-748: Move fence requests out of read threa...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/174
The CI passed (refs/remotes/origin/pr/174/head) at https://builds.apache.org/job/bookkeeper-precommit-pullrequest/21/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---