[jira] [Commented] (BIGTOP-1363) Bigtop may manage apache patches

["Guo Ruijing (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051227#comment-14051227 ] 

Guo Ruijing commented on BIGTOP-1363:
-------------------------------------

solution: bigtop do different patches before build.

existing function in package.mk:

        if [ -f $(BASE_DIR)/bigtop-packages/src/common/$($(PKG)_NAME)/series ]; then    \
          PATCHES="`cat $(BASE_DIR)/bigtop-packages/src/common/$($(PKG)_NAME)/series`" ;\
        elif [ -f $(BASE_DIR)/bigtop-packages/src/common/$($(PKG)_NAME)/patch ]; then   \
          PATCHES="patch"                                                              ;\
        else                                                                            \
          PATCHES="/dev/null"                                                          ;\
        fi ; (cd $(BASE_DIR)/bigtop-packages/src/common/$($(PKG)_NAME); cat $$PATCHES)| \
             (cd $(PKG_BUILD_DIR)/tar/$($(PKG)_NAME)-$(PKG_PKG_VERSION)$(BIGTOP_BUILD_STAMP) ; patch -p0)

> Bigtop may manage apache patches
> --------------------------------
>
>                 Key: BIGTOP-1363
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1363
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Guo Ruijing
>
> Bigtop may manage apache patches.
> Motivation 1: component build fails due to some apache patches
> Example 1) Hadoop build fails in bigtop-0.6.0/bigtop-0.7.0 build fails due to HADOOP-10110.patch missing.
> Example 2) flume 1.4.0 build fails due to Flume-2172
> Motivation 2: third party can use bigtop to manage apache or vendor patches (Not bigtop goal, but if more people use bigtop to do distribution, bigtop is more stable)



--
This message was sent by Atlassian JIRA
(v6.2#6252)