You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "C. Michael Pilato" <cm...@collab.net> on 2013/03/27 15:56:40 UTC

Re: svn commit: r1461335 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs_base/fs.c libsvn_fs_fs/fs_fs.c libsvn_fs_fs/fs_fs.h libsvn_repos/dump.c

On 03/26/2013 06:03 PM, danielsh@apache.org wrote:
> Author: danielsh
> Date: Tue Mar 26 22:03:19 2013
> New Revision: 1461335
> 
> URL: http://svn.apache.org/r1461335
> Log:
> FS: Allow the 'verify' API to run against transaction roots.
> 
> * subversion/include/svn_fs.h
>   (svn_fs_verify_rev): Change signature.

This function needs a new name.  I suggest "svn_fs_verify_root" (and no, I'm
not concerned about confusion with other meanings of "root" within this FS
context).

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development


Re: svn commit: r1461335 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs_base/fs.c libsvn_fs_fs/fs_fs.c libsvn_fs_fs/fs_fs.h libsvn_repos/dump.c

Posted by "C. Michael Pilato" <cm...@collab.net>.
On 03/27/2013 11:04 AM, Daniel Shahaf wrote:
> C. Michael Pilato wrote on Wed, Mar 27, 2013 at 10:56:40 -0400:
>> On 03/26/2013 06:03 PM, danielsh@apache.org wrote:
>>> Author: danielsh
>>> Date: Tue Mar 26 22:03:19 2013
>>> New Revision: 1461335
>>>
>>> URL: http://svn.apache.org/r1461335
>>> Log:
>>> FS: Allow the 'verify' API to run against transaction roots.
>>>
>>> * subversion/include/svn_fs.h
>>>   (svn_fs_verify_rev): Change signature.
>>
>> This function needs a new name.  I suggest "svn_fs_verify_root" (and no, I'm
>> not concerned about confusion with other meanings of "root" within this FS
>> context).
> 
> I'm not sure what those "other meanings" are, but I'll fix that in a
> second.

"Root directory of the filesystem", for example.

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development


Re: svn commit: r1461335 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs_base/fs.c libsvn_fs_fs/fs_fs.c libsvn_fs_fs/fs_fs.h libsvn_repos/dump.c

Posted by Daniel Shahaf <da...@apache.org>.
C. Michael Pilato wrote on Wed, Mar 27, 2013 at 10:56:40 -0400:
> On 03/26/2013 06:03 PM, danielsh@apache.org wrote:
> > Author: danielsh
> > Date: Tue Mar 26 22:03:19 2013
> > New Revision: 1461335
> > 
> > URL: http://svn.apache.org/r1461335
> > Log:
> > FS: Allow the 'verify' API to run against transaction roots.
> > 
> > * subversion/include/svn_fs.h
> >   (svn_fs_verify_rev): Change signature.
> 
> This function needs a new name.  I suggest "svn_fs_verify_root" (and no, I'm
> not concerned about confusion with other meanings of "root" within this FS
> context).

I'm not sure what those "other meanings" are, but I'll fix that in a
second.

Thanks

Daniel