You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by SangeetaGulia <gi...@git.apache.org> on 2018/02/02 17:23:33 UTC
[GitHub] carbondata pull request #1917: [CARBONDATA-2105] Fixed bug for null values w...
GitHub user SangeetaGulia opened a pull request:
https://github.com/apache/carbondata/pull/1917
[CARBONDATA-2105] Fixed bug for null values when group by column is present as dictionary_include
1) Refactored code to resolve issue of null values when group by column is present as dictionary_include.
2) Added related test case.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed? No
- [x] Any backward compatibility impacted? No
- [x] Document update required? No
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
Yes
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. (NA)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SangeetaGulia/incubator-carbondata CARBONDATA-2105
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1917.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1917
----
commit 9755b53e8f91d0e609b45bc155044f1cab278b5f
Author: SangeetaGulia <sa...@...>
Date: 2018-02-02T17:11:24Z
Fixed bug for null values when group by column is present as dictionary_include
----
---
[GitHub] carbondata pull request #1917: [CARBONDATA-2105] Fixed bug for null values w...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1917#discussion_r165811773
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala ---
@@ -544,7 +544,8 @@ class TableNewProcessor(cm: TableModel) {
val encoders = if (getEncoderFromParent(field)) {
isAggFunPresent =
cm.dataMapRelation.get.get(field).get.aggregateFunction.equalsIgnoreCase("sum") ||
- cm.dataMapRelation.get.get(field).get.aggregateFunction.equals("avg")
+ cm.dataMapRelation.get.get(field).get.aggregateFunction.equals("avg") ||
+ cm.dataMapRelation.get.get(field).get.aggregateFunction.equals("count")
--- End diff --
This will only fail when it is a dictionary column, so if in maintable column is dictionary type then only add count to measure column
---
[GitHub] carbondata pull request #1917: [CARBONDATA-2105] Fixed bug for null values w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1917
---
[GitHub] carbondata issue #1917: [CARBONDATA-2105] Fixed bug for null values when gro...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1917
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3457/
---
[GitHub] carbondata issue #1917: [CARBONDATA-2105] Fixed bug for null values when gro...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/1917
Please handle this comment in different PR
---
[GitHub] carbondata issue #1917: [CARBONDATA-2105] Fixed bug for null values when gro...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1917
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3324/
---
[GitHub] carbondata issue #1917: [CARBONDATA-2105] Fixed bug for null values when gro...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1917
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2217/
---