You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/12 11:46:33 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request #1812: Update documentation example for change in API
alamb opened a new pull request #1812:
URL: https://github.com/apache/arrow-datafusion/pull/1812
# Which issue does this PR close?
re #1587
# Rationale for this change
The example (published at https://arrow.apache.org/datafusion/user-guide/example-usage.html) is the first thing users will likely try
# What changes are included in this PR?
Update the example so it will run with changes to make more methods `async`
# Are there any user-facing changes?
Just docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1812: Update documentation example for change in API
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1812:
URL: https://github.com/apache/arrow-datafusion/pull/1812#discussion_r808337196
##########
File path: docs/source/user-guide/example-usage.md
##########
@@ -19,7 +19,16 @@
# Example Usage
-Run a SQL query against data stored in a CSV:
+## Update `Cargo.toml`
+
+Add the following to your `Cargo.toml` file:
+
+```yaml
Review comment:
```suggestion
```toml
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1812: Update documentation example for change in API
Posted by GitBox <gi...@apache.org>.
xudong963 commented on a change in pull request #1812:
URL: https://github.com/apache/arrow-datafusion/pull/1812#discussion_r807469469
##########
File path: docs/source/user-guide/example-usage.md
##########
@@ -28,18 +37,18 @@ use datafusion::prelude::*;
async fn main() -> datafusion::error::Result<()> {
// register the table
let mut ctx = ExecutionContext::new();
- ctx.register_csv("example", "tests/example.csv", CsvReadOptions::new())?;
+ ctx.register_csv("example", "tests/example.csv", CsvReadOptions::new()).await?;
Review comment:
Amazing! unexpectedly, no `.await` before.
##########
File path: docs/source/user-guide/example-usage.md
##########
@@ -19,7 +19,16 @@
# Example Usage
-Run a SQL query against data stored in a CSV:
+## Update `Cargo.toml`
+
+Add the following to your `Cargo.toml` file:
+
+```yaml
Review comment:
In fact, we can directly use ```toml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1812: Update documentation example for change in API
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1812:
URL: https://github.com/apache/arrow-datafusion/pull/1812#issuecomment-1042090368
Thanks for the review @xudong963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1812: Update documentation example for change in API
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1812:
URL: https://github.com/apache/arrow-datafusion/pull/1812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1812: Update documentation example for change in API
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1812:
URL: https://github.com/apache/arrow-datafusion/pull/1812#discussion_r807197195
##########
File path: docs/source/user-guide/example-usage.md
##########
@@ -19,7 +19,16 @@
# Example Usage
-Run a SQL query against data stored in a CSV:
+## Update `Cargo.toml`
+
+Add the following to your `Cargo.toml` file:
+
+```yaml
+datafusion = "7.0.0-alpha"
Review comment:
```suggestion
datafusion = "7.0.0"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org