[GitHub] mccheah commented on a change in pull request #14: Pluggable file I/O submodule in TableOperations

[GitBox <gi...@apache.org>]

mccheah commented on a change in pull request #14: Pluggable file I/O submodule in TableOperations
URL: https://github.com/apache/incubator-iceberg/pull/14#discussion_r240408506
 
 

 ##########
 File path: core/src/main/java/com/netflix/iceberg/BaseMetastoreTableOperations.java
 ##########
 @@ -129,24 +132,13 @@ protected void refreshFromMetadataLocation(String newLocation, int numRetries) {
   }
 
   @Override
-  public InputFile newInputFile(String path) {
-    return fromLocation(path, conf);
+  public String resolveMetadataPath(String fileName) {
+    return newMetadataLocation(baseLocation, fileName);
 
 Review comment:
   `new` indicates the file is always going to be created, which is not necessarily the case. `resolve` I like because it doesn't necessarily indicate work to create the thing, but it indicates that it's finding the path or resolving the file name against some base path.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services