You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/02/10 14:28:00 UTC
[jira] [Commented] (SOLR-13996) Refactor
HttpShardHandler#prepDistributed() into smaller pieces
[ https://issues.apache.org/jira/browse/SOLR-13996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033639#comment-17033639 ]
ASF subversion and git services commented on SOLR-13996:
--------------------------------------------------------
Commit c65b97665c61116632bc93e5f88f84bdb5cccf21 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=c65b976 ]
SOLR-13996: Refactor HttpShardHandler.prepDistributed method (#1220)
SOLR-13996: Refactor HttpShardHandler.prepDistributed method into smaller pieces
This commit introduces an interface named ReplicaSource which is marked as experimental. It has two sub-classes named CloudReplicaSource (for solr cloud) and LegacyReplicaSource for non-cloud clusters. The prepDistributed method now calls out to these sub-classes depending on whether the cluster is running on cloud mode or not.
> Refactor HttpShardHandler#prepDistributed() into smaller pieces
> ---------------------------------------------------------------
>
> Key: SOLR-13996
> URL: https://issues.apache.org/jira/browse/SOLR-13996
> Project: Solr
> Issue Type: Improvement
> Reporter: Ishan Chattopadhyaya
> Assignee: Shalin Shekhar Mangar
> Priority: Major
> Attachments: SOLR-13996.patch, SOLR-13996.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, it is very hard to understand all the various things being done in HttpShardHandler. I'm starting with refactoring the prepDistributed() method to make it easier to grasp. It has standalone and cloud code intertwined, and wanted to cleanly separate them out. Later, we can even have two separate method (for standalone and cloud, each).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org