[GitHub] [incubator-yunikorn-core] yangwwei commented on pull request #365: [YUNIKORN-949] Location of the state dump file should be configurable

[GitBox <gi...@apache.org>]

yangwwei commented on pull request #365:
URL: https://github.com/apache/incubator-yunikorn-core/pull/365#issuecomment-1020717823


   hi @anuraagnalluri thanks for the PR, I did a quick review. @pbacsko please help to review this patch.
   
   >However, when I edit the configmap, I don't see the environment variable change in the scheduler pod even after 30 min. I read about config hot refresh here, but am missing a few details. Is the hot refresh enabled by default, and if so, how long does it typically take?
   
   Yes, it is enabled by default. YK loads configs from the configmap, and it keeps watching the configmap object, if some fields changes, YK does a reload and load all new values to memory.  But here it seems to be a bit different. Because you are directly fetching ENV var using the os library, you can only expect that work unless the ENV updates got propagated to the docker container.  And that is very unlikely not the case, you can see a similar post [here](https://stackoverflow.com/questions/45050050/can-i-modify-containers-environment-variables-without-restarting-pod-using-kube). If we want this to be a config supports hot-refresh, it cannot be a ENV var, it can be a partition level config property in the configmap, and it needs a bit more effort to load/reload that property on changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org