You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2020/03/17 19:32:36 UTC

[GitHub] [fluo-uno] ctubbsii opened a new pull request #242: Fix #240 Add ZK lib dir to Accumulo class path

ctubbsii opened a new pull request #242: Fix #240 Add ZK lib dir to Accumulo class path
URL: https://github.com/apache/fluo-uno/pull/242
 
 
   Add ZooKeeper 3.5.7's lib directory to Accumulo 2.0.0's class path in
   conf/accumulo-env.sh

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-uno] keith-turner commented on a change in pull request #242: Fix #240 Add ZK lib dir to Accumulo class path

Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #242: Fix #240 Add ZK lib dir to Accumulo class path
URL: https://github.com/apache/fluo-uno/pull/242#discussion_r394000911
 
 

 ##########
 File path: bin/impl/install/accumulo.sh
 ##########
 @@ -59,6 +59,9 @@ else
   $SED "s#instance[.]zookeepers=localhost:2181#instance.zookeepers=$UNO_HOST:2181#" "$conf"/accumulo-client.properties
   $SED "s#auth[.]principal=#auth.principal=$ACCUMULO_USER#" "$conf"/accumulo-client.properties
   $SED "s#auth[.]token=#auth.token=$ACCUMULO_PASSWORD#" "$conf"/accumulo-client.properties
+  if [[ $ACCUMULO_VERSION =~ ^2\.0\.0.*$ ]]; then
 
 Review comment:
   I wonder it 1.9 and 1.10 work.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-uno] ctubbsii commented on a change in pull request #242: Fix #240 Add ZK lib dir to Accumulo class path

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #242: Fix #240 Add ZK lib dir to Accumulo class path
URL: https://github.com/apache/fluo-uno/pull/242#discussion_r394090795
 
 

 ##########
 File path: bin/impl/install/accumulo.sh
 ##########
 @@ -59,6 +59,9 @@ else
   $SED "s#instance[.]zookeepers=localhost:2181#instance.zookeepers=$UNO_HOST:2181#" "$conf"/accumulo-client.properties
   $SED "s#auth[.]principal=#auth.principal=$ACCUMULO_USER#" "$conf"/accumulo-client.properties
   $SED "s#auth[.]token=#auth.token=$ACCUMULO_PASSWORD#" "$conf"/accumulo-client.properties
+  if [[ $ACCUMULO_VERSION =~ ^2\.0\.0.*$ ]]; then
 
 Review comment:
   Probably... but I have not tested. It's probably best that, if you want to run Uno with one of those versions of Accumulo, you do so by changing the ZooKeeper version as well, to the version that Accumulo has been tested with (3.4.14 is probably best).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-uno] keith-turner commented on a change in pull request #242: Fix #240 Add ZK lib dir to Accumulo class path

Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #242: Fix #240 Add ZK lib dir to Accumulo class path
URL: https://github.com/apache/fluo-uno/pull/242#discussion_r394000911
 
 

 ##########
 File path: bin/impl/install/accumulo.sh
 ##########
 @@ -59,6 +59,9 @@ else
   $SED "s#instance[.]zookeepers=localhost:2181#instance.zookeepers=$UNO_HOST:2181#" "$conf"/accumulo-client.properties
   $SED "s#auth[.]principal=#auth.principal=$ACCUMULO_USER#" "$conf"/accumulo-client.properties
   $SED "s#auth[.]token=#auth.token=$ACCUMULO_PASSWORD#" "$conf"/accumulo-client.properties
+  if [[ $ACCUMULO_VERSION =~ ^2\.0\.0.*$ ]]; then
 
 Review comment:
   I wonder if 1.9 and 1.10 work with this newer version of ZK.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-uno] ctubbsii merged pull request #242: Fix #240 Add ZK lib dir to Accumulo class path

Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #242: Fix #240 Add ZK lib dir to Accumulo class path
URL: https://github.com/apache/fluo-uno/pull/242
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services