You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Jason van Zyl <jv...@sonatype.com> on 2008/11/17 14:22:59 UTC

Re: svn commit: r718176 - in /maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/builder: PomClassicDomainModel.java impl/DefaultProjectBuilder.java listeners/BuildExtensionListener.java

On 17-Nov-08, at 1:23 AM, sisbell@apache.org wrote:

> Author: sisbell
> Date: Sun Nov 16 22:23:46 2008
> New Revision: 718176
>
> URL: http://svn.apache.org/viewvc?rev=718176&view=rev
> Log:
> Configured build extension listener to only fire on poms within the  
> build.
>

It's not only with the current reactor, but the partitioned search  
must also take into account any extensions that occur in the ancestry  
of any POMs in the reactor. Extensions found in dependencies or  
plugins don't matter in this case but it's highly likely that an  
organizational POM will describe an extension used for deployment to  
WebDAV and that POM will not be in the current reactor.

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
jason at sonatype dot com
----------------------------------------------------------

People develop abstractions by generalizing from concrete examples.
Every attempt to determine the correct abstraction on paper without
actually developing a running system is doomed to failure. No one
is that smart. A framework is a resuable design, so you develop it by
looking at the things it is supposed to be a design of. The more  
examples
you look at, the more general your framework will be.

   -- Ralph Johnson & Don Roberts, Patterns for Evolving Frameworks


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r718176 - in /maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/builder: PomClassicDomainModel.java impl/DefaultProjectBuilder.java listeners/BuildExtensionListener.java

Posted by Shane Isbell <sh...@gmail.com>.
It will pick up extensions in ancestry as well, since the search is applied
after inheritance has been completed.

Shane

On Mon, Nov 17, 2008 at 5:22 AM, Jason van Zyl <jv...@sonatype.com> wrote:

>
> On 17-Nov-08, at 1:23 AM, sisbell@apache.org wrote:
>
>  Author: sisbell
>> Date: Sun Nov 16 22:23:46 2008
>> New Revision: 718176
>>
>> URL: http://svn.apache.org/viewvc?rev=718176&view=rev
>> Log:
>> Configured build extension listener to only fire on poms within the build.
>>
>>
> It's not only with the current reactor, but the partitioned search must
> also take into account any extensions that occur in the ancestry of any POMs
> in the reactor. Extensions found in dependencies or plugins don't matter in
> this case but it's highly likely that an organizational POM will describe an
> extension used for deployment to WebDAV and that POM will not be in the
> current reactor.
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder,  Apache Maven
> jason at sonatype dot com
> ----------------------------------------------------------
>
> People develop abstractions by generalizing from concrete examples.
> Every attempt to determine the correct abstraction on paper without
> actually developing a running system is doomed to failure. No one
> is that smart. A framework is a resuable design, so you develop it by
> looking at the things it is supposed to be a design of. The more examples
> you look at, the more general your framework will be.
>
>  -- Ralph Johnson & Don Roberts, Patterns for Evolving Frameworks
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>