You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/15 08:37:09 UTC

[GitHub] [incubator-shardingsphere] dongzl opened a new pull request #4320: refactor Orchestration properties with TypedProperties class.

dongzl opened a new pull request #4320: refactor Orchestration properties with TypedProperties class.
URL: https://github.com/apache/incubator-shardingsphere/pull/4320
 
 
   For #4309 , For #4270 .
   
   Changes proposed in this pull request:
   - refactor orchestration apollo, nacos, Zookeeper properties with TypedProperties class.
   - refactor orchestration facade overwrite properties with Orchestration TypedProperties class.
   - fixes orchestration Zookeeper properties key name.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4320: refactor Orchestration properties with TypedProperties class.

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4320: refactor Orchestration properties with TypedProperties class.
URL: https://github.com/apache/incubator-shardingsphere/pull/4320#discussion_r379825607
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloPropertiesEnum.java
 ##########
 @@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.orchestration.center.instance;
+
+import com.ctrip.framework.apollo.core.ConfigConsts;
+import com.ctrip.framework.apollo.openapi.client.constant.ApolloOpenApiConstants;
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+import org.apache.shardingsphere.underlying.common.constant.properties.TypedPropertiesKey;
+
+/**
+ * Apollo properties enum.
+ *
+ * @author dongzonglei
+ */
+@RequiredArgsConstructor
+@Getter
+public enum ApolloPropertiesEnum implements TypedPropertiesKey {
+    
+    APP_ID("appId", "APOLLO_SHARDING_SPHERE", String.class),
 
 Review comment:
   Javadoc for enum entry.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4320: refactor Orchestration properties with TypedProperties class.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4320: refactor Orchestration properties with TypedProperties class.
URL: https://github.com/apache/incubator-shardingsphere/pull/4320#issuecomment-586571037
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320?src=pr&el=h1) Report
   > Merging [#4320](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/18e9025c179b853b3c26511f770056e9f36af75e?src=pr&el=desc) will **increase** coverage by `0.05%`.
   > The diff coverage is `68.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4320      +/-   ##
   ============================================
   + Coverage     56.52%   56.57%   +0.05%     
     Complexity      352      352              
   ============================================
     Files          1030     1038       +8     
     Lines         18383    18412      +29     
     Branches       3347     3345       -2     
   ============================================
   + Hits          10391    10417      +26     
   - Misses         7337     7340       +3     
     Partials        655      655
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...nstant/properties/OrchestrationPropertiesEnum.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbnN0YW50L3Byb3BlcnRpZXMvT3JjaGVzdHJhdGlvblByb3BlcnRpZXNFbnVtLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [.../orchestration/center/instance/ApolloInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb0luc3RhbmNlLmphdmE=) | `54.05% <0%> (-1.51%)` | `0 <0> (ø)` | |
   | [.../center/instance/wrapper/ApolloOpenApiWrapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL3dyYXBwZXIvQXBvbGxvT3BlbkFwaVdyYXBwZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...n/constant/properties/OrchestrationProperties.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbnN0YW50L3Byb3BlcnRpZXMvT3JjaGVzdHJhdGlvblByb3BlcnRpZXMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...tion/center/instance/CuratorZookeeperInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvQ3VyYXRvclpvb2tlZXBlckluc3RhbmNlLmphdmE=) | `40.79% <100%> (+0.47%)` | `0 <0> (ø)` | :arrow_down: |
   | [...estration/center/instance/NacosConfigInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvTmFjb3NDb25maWdJbnN0YW5jZS5qYXZh) | `66.66% <100%> (+0.87%)` | `0 <0> (ø)` | :arrow_down: |
   | [...rchestration/center/instance/ApolloProperties.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb1Byb3BlcnRpZXMuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...internal/registry/ShardingOrchestrationFacade.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vaW50ZXJuYWwvcmVnaXN0cnkvU2hhcmRpbmdPcmNoZXN0cmF0aW9uRmFjYWRlLmphdmE=) | `85.1% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...estration/center/instance/NacosPropertiesEnum.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvTmFjb3NQcm9wZXJ0aWVzRW51bS5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...ation/center/instance/ZookeeperPropertiesEnum.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvWm9va2VlcGVyUHJvcGVydGllc0VudW0uamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
   | ... and [12 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320?src=pr&el=footer). Last update [18e9025...7a1abcf](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4320?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl merged pull request #4320: refactor Orchestration properties with TypedProperties class.

Posted by GitBox <gi...@apache.org>.
dongzl merged pull request #4320: refactor Orchestration properties with TypedProperties class.
URL: https://github.com/apache/incubator-shardingsphere/pull/4320
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4320: refactor Orchestration properties with TypedProperties class.

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4320: refactor Orchestration properties with TypedProperties class.
URL: https://github.com/apache/incubator-shardingsphere/pull/4320#issuecomment-586571242
 
 
   ## Pull Request Test Coverage Report for [Build 9562](https://coveralls.io/builds/28749814)
   
   * **40** of **58**   **(68.97%)**  changed or added relevant lines in **14** files are covered.
   * **2** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.05%**) to **60.189%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/constant/properties/OrchestrationProperties.java](https://coveralls.io/builds/28749814/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fconstant%2Fproperties%2FOrchestrationProperties.java#L30) | 0 | 2 | 0.0%
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/constant/properties/OrchestrationPropertiesEnum.java](https://coveralls.io/builds/28749814/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fconstant%2Fproperties%2FOrchestrationPropertiesEnum.java#L28) | 0 | 2 | 0.0%
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28749814/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L64) | 0 | 3 | 0.0%
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/wrapper/ApolloOpenApiWrapper.java](https://coveralls.io/builds/28749814/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2Fwrapper%2FApolloOpenApiWrapper.java#L46) | 0 | 11 | 0.0%
   <!-- | **Total:** | **40** | **58** | **68.97%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28749814/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L67) | 1 | 59.46% |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/wrapper/ApolloOpenApiWrapper.java](https://coveralls.io/builds/28749814/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2Fwrapper%2FApolloOpenApiWrapper.java#L58) | 1 | 0% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28749814/badge)](https://coveralls.io/builds/28749814) |
   | :-- | --: |
   | Change from base [Build 9560](https://coveralls.io/builds/28749196): |  0.05% |
   | Covered Lines: | 11082 |
   | Relevant Lines: | 18412 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services